From: Dmitry Gutov <dgutov@yandex.ru>
To: Alan Mackenzie <acm@muc.de>
Cc: Angelo Graziosi <angelo.g0@libero.it>, emacs-devel@gnu.org
Subject: Re: Error in C++ mode with Emacs 27.0.90
Date: Sat, 4 Apr 2020 15:52:42 +0300 [thread overview]
Message-ID: <1a75181b-8f2f-6373-1aa6-f67efdabffff@yandex.ru> (raw)
In-Reply-To: <20200404114638.GC5329@ACM>
On 04.04.2020 14:46, Alan Mackenzie wrote:
>>> It seems unlikely that we can get a nested list (in imenu--index-alist)
>>> with only one element. I have tried creating a C++ buffer with 25
>>> functions in it. This gives a simple list of 25 elements. With 26
>>> functions, I get a nested alist with two elements.
>
>> What's the worst that can happen in this case? We get a nested submenu
>> with just one element?
>
> Probably.
Doesn't sound too scary.
>> If you're implying we can get rid of the check and always return (cdr
>> menu), I say let's try.
>
> I think we can get rid of the check and just use (cdr menu), yes. In
> master, that is.
Ok.
> Maybe for the release branch he would let in a patch like the one I've
> already applied.
Would you like to propose one? Given that we'd be copying your code anyway.
> imenu is _complicated_.
I think it's just overdoing with its list-of-lists approach, instead of
proper structs. And it seems like we're dealing with extraneous code
anyway (maybe even a premature optimization of sorts).
next prev parent reply other threads:[~2020-04-04 12:52 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-24 20:50 Error in C++ mode with Emacs 27.0.90 Angelo Graziosi
2020-03-27 15:56 ` Angelo Graziosi
2020-03-28 15:19 ` Alan Mackenzie
2020-03-28 17:34 ` Angelo Graziosi
2020-03-28 20:10 ` Alan Mackenzie
2020-03-28 22:31 ` Angelo Graziosi
2020-03-29 11:58 ` Alan Mackenzie
2020-03-29 13:56 ` Eli Zaretskii
2020-03-30 17:49 ` Alan Mackenzie
2020-03-30 18:36 ` Eli Zaretskii
2020-03-30 19:46 ` Alan Mackenzie
2020-03-28 23:18 ` Dmitry Gutov
2020-03-29 11:50 ` Alan Mackenzie
2020-03-29 22:32 ` Dmitry Gutov
2020-04-04 11:46 ` Alan Mackenzie
2020-04-04 12:52 ` Dmitry Gutov [this message]
2023-02-18 17:52 ` Alan Mackenzie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a75181b-8f2f-6373-1aa6-f67efdabffff@yandex.ru \
--to=dgutov@yandex.ru \
--cc=acm@muc.de \
--cc=angelo.g0@libero.it \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).