From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: =?UTF-8?Q?Cl=c3=a9ment_Pit-Claudel?= Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Add new function to test whether a key is present in a hash table. Date: Thu, 15 Feb 2018 17:03:43 -0500 Message-ID: <1a13b319-a308-c42d-507e-50dec2137fc2@gmail.com> References: <20180215203406.64372-1-phst@google.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1518732220 9473 195.159.176.226 (15 Feb 2018 22:03:40 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 15 Feb 2018 22:03:40 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Feb 15 23:03:35 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1emRcj-0001Yu-CP for ged-emacs-devel@m.gmane.org; Thu, 15 Feb 2018 23:03:25 +0100 Original-Received: from localhost ([::1]:36318 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1emRel-0004Qj-9r for ged-emacs-devel@m.gmane.org; Thu, 15 Feb 2018 17:05:31 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54687) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1emRd7-0004MF-Eu for emacs-devel@gnu.org; Thu, 15 Feb 2018 17:03:50 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1emRd4-0007ce-Ca for emacs-devel@gnu.org; Thu, 15 Feb 2018 17:03:49 -0500 Original-Received: from mail-io0-x231.google.com ([2607:f8b0:4001:c06::231]:46103) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1emRd4-0007cQ-78 for emacs-devel@gnu.org; Thu, 15 Feb 2018 17:03:46 -0500 Original-Received: by mail-io0-x231.google.com with SMTP id p78so2245978iod.13 for ; Thu, 15 Feb 2018 14:03:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=jzF1FdQqfrSnOYQibySAqhx1seXIF2hrfm5wfjyAMMw=; b=gyFbZEOd2HVbQX/IjYHI5xRVKHy4vm9WKRqf+T7Ogl+fsFI1Y9rPD/Rgp4JQ5XvvSF q2dZ4MROYJ7r7NUrf/94csPmyFcUcTo1kH7KC3yWPuOjMqZqT/1zr4EjY4S/nTcOoV5E 7mqfWCgCxAy1dokcNePBm9vrcPQoPm6tfWmyrnFmNaeauEaIa+0E3EKUOEEqScUA2cWo hf4YVbvXoHxhzjggOGPFuRxXEVoeIfbngqrjqOssYOD4Gjo98S4UBq3WFmciqsEUo7Be cig6ZZ4HobecGYUvj0VRHXISAe2aBm6O+oOGyQxL2PJr/0ywc7UX8NFUmW5DJOuTvpOF Bm+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=jzF1FdQqfrSnOYQibySAqhx1seXIF2hrfm5wfjyAMMw=; b=NyI9tuiwZlIKCHceeBFZf++LbF5lL1kj9AIGKzICPiX8WD63YnBNOwDxTjdr49BDFo xf3aXGSz4oi4K0mJ+816gLr6gk+/wocs9gPJSuhUPg23Yt17pkf6YjIPQX509kcDi01O En472X4Uso54gJ16rbQVgk2ffL7Sl7+28P7e3qcBi0Zuyi8JzQ9UIQGb8DSkRtxxu+Pa hMO6PAdzyPL698J8OFCrpMccW6l/gocwklPsuN5JFi3ImhJf/xELSRDP4sI9/RChkFb4 iJ+K4L7U25R3u1iGBC2ge8H/Mf0RrSMGosYSXrYus/n1peZj3w2Ip3NZr6zuyDLZ8L3C ht/g== X-Gm-Message-State: APf1xPCZLcOxZ2S9KBTio7M2WG8TXsOyCeryg8k6JXtnBKT4WIO8uFUu 2jZYzs9/pLC3GQDA4TdvInm7q/qD X-Google-Smtp-Source: AH8x225jZAL0rE5xP/ZLSXGpdhYURFDlHndEpHGg0duIetVMHpRH5euuiqUW82EMGR2UV/yniKnJIw== X-Received: by 10.107.53.221 with SMTP id k90mr5572208ioo.6.1518732225029; Thu, 15 Feb 2018 14:03:45 -0800 (PST) Original-Received: from [18.26.2.123] (26-2-123.dynamic.csail.mit.edu. [18.26.2.123]) by smtp.gmail.com with ESMTPSA id i40sm1025606ioo.57.2018.02.15.14.03.44 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 15 Feb 2018 14:03:44 -0800 (PST) In-Reply-To: <20180215203406.64372-1-phst@google.com> Content-Language: en-GB X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4001:c06::231 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:222775 Archived-At: On 2018-02-15 15:34, Philipp Stephani wrote: > Such a function is useful because in Emacs Lisp, 'gethash' cannot > return whether the key is present as in Common Lisp, and using > 'gethash' alone to test for presence is nontrivial. Looks useful to me :) Maybe the function should be called …-contains-key-p instead of …-contains-key? Clément.