From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.devel Subject: Re: feature/tree-sitter 3069849bd4 4/4: * src/treesit.c (treesit_load_language): Fix uninitialized uses. Date: Tue, 22 Nov 2022 17:52:40 -0800 Message-ID: <1FD6B186-446B-41D4-875B-02FB501338E0@gmail.com> References: <87ilj85xi7.fsf@yahoo.com> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16063"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Nov 23 02:53:12 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oxewp-0003yS-Uv for ged-emacs-devel@m.gmane-mx.org; Wed, 23 Nov 2022 02:53:11 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oxewR-0008My-Q9; Tue, 22 Nov 2022 20:52:47 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oxewP-0008L3-Os for emacs-devel@gnu.org; Tue, 22 Nov 2022 20:52:45 -0500 Original-Received: from mail-pl1-x634.google.com ([2607:f8b0:4864:20::634]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oxewO-0000Co-5f for emacs-devel@gnu.org; Tue, 22 Nov 2022 20:52:45 -0500 Original-Received: by mail-pl1-x634.google.com with SMTP id io19so15349160plb.8 for ; Tue, 22 Nov 2022 17:52:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=mrrxbavij5nYGGZmpVxyvgqoppu1ZJsy8kaorRMZ840=; b=Cb+GxKmecWbpq+dg1fXEVPqwB9tX39zFavmhx6FU95oWyhmQnL7TUZsPdVxVxWMT+R LwouHqEmoYN1ODXnxmNv+3n+/KGib8DZbHqUMqPlm73LUjwHxYdv8EBz+yF+NudAIsit GPOgUATRBNrJTn0RhtHYX7aWoJt3l5+1CsqrALMeH58QJpjwsppkEHCYWVYk9vHO51ax YoEw/iMEwljuJKnvfiutQq4pDzeFMeUF+skgJe4Mk7KfHwnjrxS4sNDUl4iupGL69IzQ Yb01JzgebucPXVdZM3s0PFH0v2MMmUezXS3EZXMzS3o2Sellwieh9Wy4xWEIBxq6vKxC /4Fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mrrxbavij5nYGGZmpVxyvgqoppu1ZJsy8kaorRMZ840=; b=kqavFBgVf0nVq3ut06LbvIzBI0cGoXIXzM6w+uDeH3BVZM8D0y0vRu/NBKX/BGXdb8 ZZXloUFHYQozWJeLdZUNH9f+7e2tWhT3qhQn1Omy5wCE6Nv7gq7puLCjMBghjIudm8ez yvFtZxYdh2SYBi3cY3Ppx7SkHZjVZYtNDKD/ys5Q+CCMA5zdHAWypjgW/vwGRLLr6VJH AggAxgTg6Lwq30VlXg5/YxrYLRxZaNOMgNZ+CZJ9XyKhGHy0xndnUkQSGykIB5UkJO58 /obvIbNYyCZuHb7dDfVG3dkhBsIppt2xNAeExpUN7vj2pupKmjdrfIJvlkQj2NemjrxC I7gw== X-Gm-Message-State: ANoB5pl+9XQPyQGjo88NbpZkW0BRxAKHmEL3I0lISCxWBsbWThrzjzmb 3ZYworbsVdLuu9lZdr1DsQY= X-Google-Smtp-Source: AA0mqf4aMEUg1exNe34qqbMAdNA9YdZVmLMkHORS/O7I2ZAnbp6YLC9S1QPuRbvse8jaTtZi2RhFhg== X-Received: by 2002:a17:903:130c:b0:189:26bb:3ba2 with SMTP id iy12-20020a170903130c00b0018926bb3ba2mr8274267plb.96.1669168362634; Tue, 22 Nov 2022 17:52:42 -0800 (PST) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id z1-20020a655a41000000b00439c6a4e1ccsm5117088pgs.62.2022.11.22.17.52.41 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 22 Nov 2022 17:52:42 -0800 (PST) In-Reply-To: <87ilj85xi7.fsf@yahoo.com> X-Mailer: Apple Mail (2.3696.120.41.1.1) Received-SPF: pass client-ip=2607:f8b0:4864:20::634; envelope-from=casouri@gmail.com; helo=mail-pl1-x634.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:300369 Archived-At: > >> Thanks for working on this. What does ??? mean? Why do we assume >> handle is not NULL? > > handle can only be set if tail is non-nil, but I do not think that is > always the case. > > The code below seemed to call dynlib_sym (handle, c_name) without any > checks. I was going to ask about it, but I forgot. Cool! I made a tiny change to it. Yuan