From: Yuan Fu <casouri@gmail.com>
To: Po Lu <luangruo@yahoo.com>
Cc: emacs-devel <emacs-devel@gnu.org>
Subject: Re: feature/tree-sitter 3069849bd4 4/4: * src/treesit.c (treesit_load_language): Fix uninitialized uses.
Date: Tue, 22 Nov 2022 17:52:40 -0800 [thread overview]
Message-ID: <1FD6B186-446B-41D4-875B-02FB501338E0@gmail.com> (raw)
In-Reply-To: <87ilj85xi7.fsf@yahoo.com>
>
>> Thanks for working on this. What does ??? mean? Why do we assume
>> handle is not NULL?
>
> handle can only be set if tail is non-nil, but I do not think that is
> always the case.
>
> The code below seemed to call dynlib_sym (handle, c_name) without any
> checks. I was going to ask about it, but I forgot.
Cool! I made a tiny change to it.
Yuan
prev parent reply other threads:[~2022-11-23 1:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-21 9:37 feature/tree-sitter 3069849bd4 4/4: * src/treesit.c (treesit_load_language): Fix uninitialized uses Yuan Fu
2022-11-21 11:59 ` Po Lu
2022-11-23 1:52 ` Yuan Fu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1FD6B186-446B-41D4-875B-02FB501338E0@gmail.com \
--to=casouri@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=luangruo@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).