From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Maguire, Andrew \(GE Infra, Energy\)" Newsgroups: gmane.emacs.devel Subject: RE: show-paren-mode prevents page-down from displaying next 1/2 page. Date: Thu, 19 Apr 2007 13:46:56 +0200 Message-ID: <1F26F4742242BA449B1716A3A1E93EC60BFC356A@BFTMLVEM02.e2k.ad.ge.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable X-Trace: sea.gmane.org 1177012057 27472 80.91.229.12 (19 Apr 2007 19:47:37 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 19 Apr 2007 19:47:37 +0000 (UTC) Cc: rms@gnu.org, emacs-devel@gnu.org To: "Glenn Morris" , "Chong Yidong" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Apr 19 21:47:31 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1HecbH-0005pY-4D for ged-emacs-devel@m.gmane.org; Thu, 19 Apr 2007 21:47:27 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HecgF-0001WM-Ip for ged-emacs-devel@m.gmane.org; Thu, 19 Apr 2007 15:52:35 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HeVBO-0006Hw-HQ for emacs-devel@gnu.org; Thu, 19 Apr 2007 07:52:14 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HeVBM-0006Hk-IS for emacs-devel@gnu.org; Thu, 19 Apr 2007 07:52:13 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HeVBL-0006Hh-Uu for emacs-devel@gnu.org; Thu, 19 Apr 2007 07:52:11 -0400 Original-Received: from ext-nj2ut-12.online-age.net ([64.14.54.245]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1HeV6M-0000eM-Ds; Thu, 19 Apr 2007 07:47:02 -0400 Original-Received: from int-nj2ut-2.online-age.net (int-nj2ut-2.online-age.net [3.159.237.71]) by ext-nj2ut-12.online-age.net (8.13.6/8.13.6/20051114-SVVS-TLS-DNSBL) with ESMTP id l3JBl1Wi018114; Thu, 19 Apr 2007 07:47:01 -0400 Original-Received: from cinmlef07.e2k.ad.ge.com (int-nj2ut-2.online-age.net [3.159.237.71]) by int-nj2ut-2.online-age.net (8.13.6/8.13.6/20050510-SVVS) with ESMTP id l3JBkwVc020832; Thu, 19 Apr 2007 07:47:01 -0400 Original-Received: from BFTMLVEM02.e2k.ad.ge.com ([3.159.56.35]) by cinmlef07.e2k.ad.ge.com with Microsoft SMTPSVC(6.0.3790.2499); Thu, 19 Apr 2007 07:46:58 -0400 X-MimeOLE: Produced By Microsoft Exchange V6.0.6603.0 Content-class: urn:content-classes:message X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: show-paren-mode prevents page-down from displaying next 1/2 page. Thread-Index: AceCT2hQ4HKn1eQdRluQGJyxqB/t5wAIYliwAAFBmCA= X-OriginalArrivalTime: 19 Apr 2007 11:46:58.0593 (UTC) FILETIME=[6FC0A110:01C78278] X-detected-kernel: Linux 2.4 (Opera?) X-Mailman-Approved-At: Thu, 19 Apr 2007 15:51:58 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:69657 Archived-At: Hmm, I thought I would play a bit more and there is still something strange going on, I have not been able to write some repeatable code yet = though. My reason for looking further was that the fix includes a check for = window-start when dir is -1 but no check for when dir is 1. So I thought I would try = and provoke a mirror case with scroll-down ie. when dir is 1 and no = window-start test is used. So far I cannot find anything wrong, despite that = suspicion! However, the situation I have now uncovered seems to be related to an overlay being left behind after scroll event and then the next scroll event finds this overlay, removes it but this causes an extra window = redisplay and thus a recenter when one was not expected. Point is moved to the = correct place. Therefore, my suspicion is that it is related to the new = when test preventing the deletion of a previous overlay when one is needed but it = is outside the new window's bounds. I suspect that the when clause needs to = always set the pos variable if dir is set but only set the mismatch variable using = the test with window-start. I hope that makes sense and you see what I mean. I will try and write some test code but it may have to be next week. Thanks, Andrew "If it runs, script it!" > -----Original Message----- > From: Maguire, Andrew (GE Infra, Energy)=20 > Sent: 19 April 2007 11:55 > To: 'Glenn Morris'; Chong Yidong > Cc: rms@gnu.org; emacs-devel@gnu.org > Subject: RE: show-paren-mode prevents page-down from=20 > displaying next 1/2 > page. >=20 >=20 > Yes, that patch fixes the behaviour.=20 >=20 > Thanks for the fast response! >=20 > Andrew >=20 >=20 > > -----Original Message----- > > From: Glenn Morris [mailto:rgm@gnu.org] > > Sent: 19 April 2007 07:50 > > To: Chong Yidong > > Cc: Maguire, Andrew (GE Infra, Energy); rms@gnu.org;=20 > > emacs-devel@gnu.org > > Subject: Re: show-paren-mode prevents page-down from=20 > > displaying next 1/2 > > page. > >=20 > >=20 > > Chong Yidong wrote: > >=20 > > > This glitch occurs because show-paren-mode tries to=20 > highlight before > > > window-start, which forces the redisplay engine to=20 > recenter. It's no > > > big deal, but I believe this patch fixes it. Could someone help me > > > double-check? > >=20 > > Looks ok to me. > >=20 > >=20 >=20