Re: Frame ordering

[David Reitter <david.reitter@gmail.com>]

On Jun 13, 2010, at 8:30 PM, Stefan Monnier wrote:

>> Should Vframe_list not be updated in the event loop?
> 
> Why not update it in Fselect_frame, and obey the `norecord' argument?


Tried that - doesn't catch clicks into the frame by the user.

However, I got the code below to work at the end of do_switch_frame.   

I think this would be a substantial, and good change to the way frames are ordered.  Are you OK with this?




*** ../../em24.git/src/frame.c	2010-04-30 18:30:17.000000000 -0400
--- frame.c	2010-06-13 22:33:19.000000000 -0400
***************
*** 881,886 ****
--- 881,893 ----
       the one you're actually typing in.  */
    internal_last_event_frame = Qnil;
  
+   if (NILP (norecord))
+     {
+       BLOCK_INPUT;
+       Vframe_list = Fcons (frame, Fdelq (frame, Vframe_list));
+       UNBLOCK_INPUT;
+     }
+ 
    return frame;
  }