From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Theodor Thornhill Newsgroups: gmane.emacs.devel Subject: Re: Mode names for C-like tree-sitter modes Date: Mon, 14 Nov 2022 07:34:48 +0100 Message-ID: <1E870C80-8435-4305-8FA1-A5A8FF681E2C@thornhill.no> References: <3C23FEAC-6550-48BE-91A3-443B44717C40@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14371"; mail-complaints-to="usenet@ciao.gmane.io" To: emacs-devel@gnu.org, Yuan Fu , emacs-devel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Nov 15 02:11:18 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oukTt-0003UI-Ub for ged-emacs-devel@m.gmane-mx.org; Tue, 15 Nov 2022 02:11:18 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ouir1-000433-Qn; Mon, 14 Nov 2022 18:27:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ouih3-0007s4-Fs for emacs-devel@gnu.org; Mon, 14 Nov 2022 18:16:46 -0500 Original-Received: from out0.migadu.com ([94.23.1.103]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ouT4P-00073a-R5 for emacs-devel@gnu.org; Mon, 14 Nov 2022 01:35:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1668407748; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8SM7egtH99wzHN5GVTBY8ylT5XdOhxyCtap680BGlq4=; b=MDj6yldGwhCd2VM3an9v6cKP11LyMsxwD4tjOehTqzMRMl7LC/28sCnHzvrCKcu6NMsvVw rBBfaX4oZ5VljJkRig8FaK7RnziZxnQ/9jtNkG8DIyv8H3QiFLLLQ2fEzi7Uqx6MmfclEj VDuiODO91DJwWQHTyc1zX6XyG5dLgSJqC0IglwuT1OltwCBYdxV0/PoWOsK6gUrvDTsnT6 SBfBnimWZ1/HP+8IGyouf6GjzCtZMyINpPIwnGhbH+eozLRlc5kMBtleMlBPyhtZ6GBwGV AFeFY7A0Tufehyi2hmW1VQXoeo5Iq17wX/r5x0rzZ8+oqm/DIkCnZNm4UKsZuA== X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. In-Reply-To: <3C23FEAC-6550-48BE-91A3-443B44717C40@gmail.com> X-Migadu-Flow: FLOW_OUT Received-SPF: pass client-ip=94.23.1.103; envelope-from=theo@thornhill.no; helo=out0.migadu.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:299810 Archived-At: On 14 November 2022 02:16:13 CET, Yuan Fu wrote: >Thanks to Theo=E2=80=99s great work, we now have tree-sitter powered majo= r modes for C, C++, Java, JSON, CSS=2E Right now they are named c-ts-mode, = c++-ts-mode, java-ts-mode, etc=2E And c-ts-mode and c++-ts-mode inherits fr= om a dummy mode c-ts-mode--base-mode=2E > >I think it=E2=80=99s fair to make C, C++ and Java modes independent, sinc= e all the cc-mode options are invalidated when we use tree-sitter=2E Howeve= r, their name could be improved, IMO=2E But I can=E2=80=99t think of anythi= ng better than c-ts-mode :-) > >(neo-c-mode=E2=80=A6 just saying) > I agree and can't think of a better name either=2E=2E=2E >c-ts-mode--base-mode should probably be a public mode, since the intentio= n (IIUC) is enable users to configure C and C++ together, by adding hooks t= o this base-mode=2E So something like c-base-mode or c-ts-base-mode? > Sure! >CSS and JSON could be merged with current modes, I think=2E Css-ts-mode c= ould merge with css-mode, and json-ts-mode could be merged with js-json-mod= e=2E Or we can just have a dedicated json-mode=2E > >Theo, WDYT? > That's fine with me=2E In any case I think we should remove tree-sitter su= pport from js-json-mode (or merge them)=2E I think there exist a json-mode = in both elpa and melpa, adding another isn't the best idea I think=2E=20 Not sure what is best, really=2E My vote goes to merging css and keeping others separate, but I don't have = the strongest opinion there=2E=20 I can prepare such a patch after we decide on something=2E Theo