From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Richard Sharman Newsgroups: gmane.emacs.devel Subject: Re: patch to hilight-chg not in emacs 22.1 Date: Tue, 18 Mar 2008 22:43:53 -0400 Message-ID: <1DEEFF6E-3F47-47FE-82AC-AFFA68D3F7FF@pobox.com> References: <7C11E945-3ED3-45A0-A3D2-1F700D12BC9B@pobox.com> <8CB2E924-9CF1-4312-911C-1DA4783D19FD@pobox.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 (Apple Message framework v752.3) Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1205894664 1974 80.91.229.12 (19 Mar 2008 02:44:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 19 Mar 2008 02:44:24 +0000 (UTC) Cc: Richard Stallman , Richard, Juanma Barranquero , Emacs Devel , martin rudalics , Sharman To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Mar 19 03:44:52 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JboIN-0002I7-4r for ged-emacs-devel@m.gmane.org; Wed, 19 Mar 2008 03:44:51 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JboHm-0005Gw-UR for ged-emacs-devel@m.gmane.org; Tue, 18 Mar 2008 22:44:14 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JboHi-0005GZ-SX for emacs-devel@gnu.org; Tue, 18 Mar 2008 22:44:10 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JboHi-0005GL-1J for emacs-devel@gnu.org; Tue, 18 Mar 2008 22:44:10 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JboHh-0005GI-Re for emacs-devel@gnu.org; Tue, 18 Mar 2008 22:44:09 -0400 Original-Received: from a-sasl-fastnet.sasl.smtp.pobox.com ([207.106.133.19] helo=sasl.smtp.pobox.com) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JboHZ-0006mY-KD; Tue, 18 Mar 2008 22:44:01 -0400 Original-Received: from localhost.localdomain (localhost [127.0.0.1]) by a-sasl-fastnet.sasl.smtp.pobox.com (Postfix) with ESMTP id D9EA71C3F; Tue, 18 Mar 2008 22:44:00 -0400 (EDT) Original-Received: from [192.168.0.3] (206-248-156-91.dsl.teksavvy.com [206.248.156.91]) by a-sasl-fastnet.sasl.smtp.pobox.com (Postfix) with ESMTP id ECE6D1C3E; Tue, 18 Mar 2008 22:43:54 -0400 (EDT) In-Reply-To: X-Mailer: Apple Mail (2.752.3) X-detected-kernel: by monty-python.gnu.org: Solaris 10 (beta) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:92954 Archived-At: On 18-Mar-08, at 12:51 PM, Stefan Monnier wrote: >>>> So, I have simplified the change to hilit-chg.el and have >>>> removed the >>>> part >>>> that required the change to easy-mmode. (I think what I was >>>> previously >>>> doing was overkill anyway.) >>> >>> Thank you, this looks good. I'd only advise you to rename >>> highlight-changes-toggle-visibility to highlight-changes-visible- >>> mode >>> and define it (yet again) with define-minor-mode. > >> So, if I understand it, you are suggesting having two minor modes: >> highlight-changes-mode and highlight-changes-visible-mode? Isn't >> that >> going to be a bit confusing?? > >> If highlight-changes-mode were on then the meaning of the new mode is >> straight forward, but if it were off should it just toggle the >> flag and >> otherwise have no effect? So it affects highlight changes mode >> either >> immediately if that mode is on otherwise the next time it is >> turned on? >> I can try and it see what it's like. > > In what way are those problems different if the command is named > "highlight-changes-toggle-visibility" and implemented without > define-minor-mode? Yes, I agree it's the same thing in code. But I still think that people will find it confusing. Originally, the highlight-change-mode function had the ability to also set active and passive states (when enabling the mode) and RMS thought it would be more consistent to have the function purely toggle the mode on or off. My reaction to having two related modes was that it would be confusing but I'm not really averse to it. Richard