From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: =?iso-8859-1?Q?Jan_Dj=E4rv?= Newsgroups: gmane.emacs.devel Subject: Re: Bidi reordering engine upgraded Date: Fri, 17 Oct 2014 19:45:34 +0200 Message-ID: <1D1BD06B-BCE5-44A0-8F9D-4A7F0DF41504@swipnet.se> References: <834mv55quj.fsf@gnu.org> <543E9122.6070605@yandex.ru> <8338ap5o7l.fsf@gnu.org> <543E9A1C.2010904@yandex.ru> <831tq95m6x.fsf@gnu.org> <83zjcx450f.fsf@gnu.org> <83y4sh43zq.fsf@gnu.org> <543F41C9.3000507@yandex.ru> <83oatc4gz3.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1413567977 2053 80.91.229.3 (17 Oct 2014 17:46:17 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 17 Oct 2014 17:46:17 +0000 (UTC) Cc: Dmitry Antipov , emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Oct 17 19:46:10 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XfBbN-0004J0-C4 for ged-emacs-devel@m.gmane.org; Fri, 17 Oct 2014 19:46:09 +0200 Original-Received: from localhost ([::1]:33875 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XfBbM-0006uc-Sa for ged-emacs-devel@m.gmane.org; Fri, 17 Oct 2014 13:46:08 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34655) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XfBbF-0006uL-7M for emacs-devel@gnu.org; Fri, 17 Oct 2014 13:46:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XfBb9-00075E-Bd for emacs-devel@gnu.org; Fri, 17 Oct 2014 13:46:01 -0400 Original-Received: from mailfe06.swip.net ([212.247.154.161]:49888 helo=swip.net) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XfBay-000712-I9; Fri, 17 Oct 2014 13:45:44 -0400 X-T2-Spam-Status: No, hits=-0.5 required=5.0 tests=BAYES_05 Original-Received: from hosdjarv.se (account mj138573@tele2.se [46.59.42.57] verified) by mailfe06.swip.net (CommuniGate Pro SMTP 5.4.4) with ESMTPA id 538241851; Fri, 17 Oct 2014 19:45:35 +0200 In-Reply-To: <83oatc4gz3.fsf@gnu.org> X-Mailer: Apple Mail (2.1878.6) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 212.247.154.161 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:175526 Archived-At: Hello. 16 okt 2014 kl. 09:21 skrev Eli Zaretskii : >=20 > Anyway, it looks like the right fix for this is as follows: >=20 > =3D=3D=3D modified file 'src/xdisp.c' > --- src/xdisp.c 2014-10-14 18:10:37 +0000 > +++ src/xdisp.c 2014-10-16 07:16:49 +0000 > @@ -2303,9 +2303,6 @@ get_phys_cursor_geometry (struct window=20 > rectangle as wide as the glyph, but use a canonical character > width instead. */ > wd =3D glyph->pixel_width - 1; > -#if defined (HAVE_NTGUI) || defined (HAVE_NS) > - wd++; /* Why? */ > -#endif >=20 > x =3D w->phys_cursor.x; > if (x < 0) >=20 >=20 > I never understood why we subtract 1 pixel from the cursor glyph's > pixel_width, anyway, and w32 and ns countermanded that, as you see. > Maybe we should also limit 'wd' from below, so it is at least 1. >=20 > Jan, can you comment on these issues and on the proposed patch, > please? As you figured out, XDrawRectangle with width 0 and non-zero height = draws a 1-pixel width line. Jan D.