Re: regexp linting run in Emacs tree

["Mattias Engdegård" <mattiase@acm.org>]

[-- Attachment #1: Type: text/plain, Size: 1073 bytes --]

5 aug. 2019 kl. 00.57 skrev Paul Eggert <eggert@cs.ucla.edu>:
> 
>> relint blindly assumes default values of global variables. What about adding a `delete-dups' to make it shut up?
> 
> That would slow down and complicate the source a bit. Maybe just add the glitch to the delinter's exception list, if any.

There isn't one and I had hoped not having to add such a mechanism. Partly because it is a cop-out, and partly because it, too, would litter the source with alien comments like

  ;; relint: skip-set-duplicate

the kind of which, in my experience, tend to linger far beyond their usefulness and mystify innocent readers of the code.
(Sticking the suppressions in a separate .relint-exceptions file is not a better solution.)

What about the fairly lightweight attached patch? It's about as cheap as can be, while keeping it readable.

> Oh, thanks, I see the point now. I installed the attached.

Good, thank you. I especially like how you removed the "FIXME: replace it with something shorter" comment, since you did, in effect, do just that!


[-- Attachment #2: 0001-Shut-up-regexp-linter.patch --]
[-- Type: application/octet-stream, Size: 1283 bytes --]

From 2c648f73207813787175776e76fba426d67cb9f0 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Mattias=20Engdeg=C3=A5rd?= <mattiase@acm.org>
Date: Mon, 5 Aug 2019 12:59:53 +0200
Subject: [PATCH] Shut up regexp linter

* lisp/progmodes/fortran.el (fortran-indent-to-column):
Prevent relint from complaining about a duplicated character in the
argument to skip-chars-{forward,backward}.
---
 lisp/progmodes/fortran.el | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/lisp/progmodes/fortran.el b/lisp/progmodes/fortran.el
index f01e866f55..8f58c501e4 100644
--- a/lisp/progmodes/fortran.el
+++ b/lisp/progmodes/fortran.el
@@ -1818,7 +1818,9 @@ fortran-indent-to-column
             (let* ((char (if (stringp fortran-comment-indent-char)
                              (aref fortran-comment-indent-char 0)
                            fortran-comment-indent-char))
-                   (chars (string ?\s ?\t char)))
+                   (chars (if (memq char '(?\s ?\t))
+                              " \t"
+                            (string ?\s ?\t char))))
               (goto-char (match-end 0))
               (skip-chars-backward chars)
               (delete-region (point) (progn (skip-chars-forward chars)
-- 
2.20.1 (Apple Git-117)