From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: John Wiegley Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] /srv/bzr/emacs/trunk r99824: 2010-04-04 John Wiegley Date: Sun, 4 Apr 2010 14:27:24 -0400 Message-ID: <1B7FB02A-8391-4134-99B6-9A4A2E2777D7@gmail.com> References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 (Apple Message framework v1078) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1270442500 2272 80.91.229.12 (5 Apr 2010 04:41:40 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 5 Apr 2010 04:41:40 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Apr 05 06:41:33 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Nye7w-00075t-Ic for ged-emacs-devel@m.gmane.org; Mon, 05 Apr 2010 06:41:33 +0200 Original-Received: from localhost ([127.0.0.1]:45394 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nye7u-0001Nv-2G for ged-emacs-devel@m.gmane.org; Mon, 05 Apr 2010 00:41:30 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NyUXk-0003P1-9L for emacs-devel@gnu.org; Sun, 04 Apr 2010 14:27:32 -0400 Original-Received: from [140.186.70.92] (port=51075 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NyUXh-0003Ot-TK for emacs-devel@gnu.org; Sun, 04 Apr 2010 14:27:31 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1NyUXg-0004z9-BY for emacs-devel@gnu.org; Sun, 04 Apr 2010 14:27:29 -0400 Original-Received: from mail-qy0-f184.google.com ([209.85.221.184]:40785) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NyUXg-0004z5-8f for emacs-devel@gnu.org; Sun, 04 Apr 2010 14:27:28 -0400 Original-Received: by qyk14 with SMTP id 14so4208947qyk.14 for ; Sun, 04 Apr 2010 11:27:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:subject:mime-version :content-type:from:in-reply-to:date:cc:content-transfer-encoding :message-id:references:to:x-mailer; bh=Ff/cQmEhcWj3KNqS88Fea2c2iq5bEl/2OqlH5m/J4cw=; b=D4yyaHeqe6U6Wzj0S/rpN1qmh/DUEH84Ed8mt3q8ZcQxYRyU14Tlrfxb/j0CpIfX2r 4yxBL+bGlYoB9OtCa4XxaLqOYgp62fb//NdUDXkIsmxSAhVw6RouNZBqSc1ulbDu1tYi MODbsC/+HbiI4bRcs3cYim9ds2VFEKJEEp05A= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:mime-version:content-type:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to:x-mailer; b=vhtwEQbwio+ox6a6uN+u2ajUp3ouALWwg6xtWm0eNUZWieAGnoTN6JtWcxx+n81G/o R0hm7lG8+jlyvc1hkgQGAT2acfno008Z4iF9LF2qaIASIqV8SVx6970v1cSbJZb0L33B tyvQ3tgRVIsPqMXzvItRMVoKzSE6gPbhipZ6Q= Original-Received: by 10.224.45.16 with SMTP id c16mr1664767qaf.144.1270405646857; Sun, 04 Apr 2010 11:27:26 -0700 (PDT) Original-Received: from [192.168.9.141] (pool-74-105-230-191.nwrknj.fios.verizon.net [74.105.230.191]) by mx.google.com with ESMTPS id 4sm22929892qwe.2.2010.04.04.11.27.25 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sun, 04 Apr 2010 11:27:25 -0700 (PDT) In-Reply-To: X-Mailer: Apple Mail (2.1078) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Mailman-Approved-At: Mon, 05 Apr 2010 00:40:56 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:123178 Archived-At: On Apr 4, 2010, at 2:20 PM, Stefan Monnier wrote: > Just a few points about this last one to ido.el, which might be good = for > other people to hear as well: > - Please start your commit messages with one line that summarizes the > change (so that "bzr log --short" gives useful info). > - Don't expect the commit message (and/or the ChangeLog) to be read by > end-users, so to advertise new end-user features, put them in > etc/NEWS instead. > - Before putting extra text in the change message, think whether it > would be appropriate as a comment in the code instead. Between the > two, we usually prefer comments. Thanks, Steven, I'll make the appropriate the changes. I also thought = about the uniqify tie-in, but didn't do it this time around because in = practice it has never been that big of a deal. When there are two files = of the same name, you only get to select the most recent of the time via = virtual buffers, but this has almost always been the one I wanted = anyway. But I do agree this feature should be added for completeness, = and I'll put it on my work list. John=