unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: John Wiegley <jwiegley@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] /srv/bzr/emacs/trunk r99824: 2010-04-04 John Wiegley <jwiegley@gmail.com>
Date: Sun, 4 Apr 2010 14:27:24 -0400	[thread overview]
Message-ID: <1B7FB02A-8391-4134-99B6-9A4A2E2777D7@gmail.com> (raw)
In-Reply-To: <jwvvdc7jdf4.fsf-monnier+emacs@gnu.org>

On Apr 4, 2010, at 2:20 PM, Stefan Monnier wrote:

> Just a few points about this last one to ido.el, which might be good for
> other people to hear as well:
> - Please start your commit messages with one line that summarizes the
>  change (so that "bzr log --short" gives useful info).
> - Don't expect the commit message (and/or the ChangeLog) to be read by
>  end-users, so to advertise new end-user features, put them in
>  etc/NEWS instead.
> - Before putting extra text in the change message, think whether it
>  would be appropriate as a comment in the code instead.  Between the
>  two, we usually prefer comments.

Thanks, Steven, I'll make the appropriate the changes.  I also thought about the uniqify tie-in, but didn't do it this time around because in practice it has never been that big of a deal.  When there are two files of the same name, you only get to select the most recent of the time via virtual buffers, but this has almost always been the one I wanted anyway.  But I do agree this feature should be added for completeness, and I'll put it on my work list.

John



  reply	other threads:[~2010-04-04 18:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <E1NyK5I-00040x-CT@internal.in.savannah.gnu.org>
2010-04-04 18:20 ` [Emacs-diffs] /srv/bzr/emacs/trunk r99824: 2010-04-04 John Wiegley <jwiegley@gmail.com> Stefan Monnier
2010-04-04 18:27   ` John Wiegley [this message]
2010-04-14 11:50     ` Juanma Barranquero

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1B7FB02A-8391-4134-99B6-9A4A2E2777D7@gmail.com \
    --to=jwiegley@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).