From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Newsgroups: gmane.emacs.devel Subject: RE: isearch highlighting Date: Fri, 10 Dec 2004 08:00:40 +0100 Message-ID: <1B3ACCFD5694A94DBA4E231402B0E9ED57B008@mucmail1.sdm.de> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-Trace: sea.gmane.org 1102662093 23519 80.91.229.6 (10 Dec 2004 07:01:33 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 10 Dec 2004 07:01:33 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Dec 10 08:01:24 2004 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1CcemK-0002OK-00 for ; Fri, 10 Dec 2004 08:01:24 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CcewG-0002ED-Eb for ged-emacs-devel@m.gmane.org; Fri, 10 Dec 2004 02:11:40 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1Ccevy-0002CK-FJ for emacs-devel@gnu.org; Fri, 10 Dec 2004 02:11:22 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1Ccevx-0002Bj-Tv for emacs-devel@gnu.org; Fri, 10 Dec 2004 02:11:22 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1Ccevx-0002Ba-Qx for emacs-devel@gnu.org; Fri, 10 Dec 2004 02:11:21 -0500 Original-Received: from [192.76.162.229] (helo=world1.sdm.de) by monty-python.gnu.org with esmtp (Exim 4.34) id 1Ccelg-0003uM-5Y for emacs-devel@gnu.org; Fri, 10 Dec 2004 02:00:44 -0500 Original-Received: from localhost ([127.0.0.1] helo=world1.sdm.de) by world1.sdm.de (MTA) via esmtp id 1Ccele-0000l8-37; Fri, 10 Dec 2004 08:00:42 +0100 Original-Received: from mucns1.muc.sdm.de ([193.102.180.22]) by world1.sdm.de (MTA) via esmtp id 1Cceld-0000l2-Ps; Fri, 10 Dec 2004 08:00:41 +0100 Original-Received: by mucns1.muc.sdm.de (MTA) via esmtp from localhost ([127.0.0.1] helo=sdmmail1.sdm.de) id 1Cceld-0004ya-OA; Fri, 10 Dec 2004 08:00:41 +0100 Original-Received: from mucmail1.sdm.de ([193.102.180.175]) by sdmmail1.sdm.de with Microsoft SMTPSVC(6.0.3790.0); Fri, 10 Dec 2004 08:00:40 +0100 X-MimeOLE: Produced By Microsoft Exchange V6.5.7226.0 Content-class: urn:content-classes:message X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: isearch highlighting Thread-Index: AcTeZ3G7pRIJsmXtQOyokhzc/2zd/wAHmBvA Original-To: , X-OriginalArrivalTime: 10 Dec 2004 07:00:40.0985 (UTC) FILETIME=[F5D8A890:01C4DE85] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:30971 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:30971 Stefan Monnier wrote: >> I think it is safe to put the body of `isearch-lazy-highlight-update' >> in the `with-local-quit' block, because quit in this function can't >> lead to a corrupted state. >=20 > Agreed. I'd even put it in `while-no-input'. You might want to add OT: you mention `while-no-input' whic remembers me to a discussion about = this. is this macro now available or have i misunderstood here something?? Klaus > the patch below, tho, just so the code can't be interrupted after > placing the new overlay but before it's recorded on the list. There > might be other similar issues, I haven't checked. >=20 >> It seems this change is unrelated to the >> proposed solution of a new form of really hard C-g (which is useful >> to interrupt the code which can put the process in a corrupted >> state).=20 >=20 > Of course. The idea of a "really hard C-g" is to work around > problems,=20 > but it should not be an excuse to not fix those problems. >=20 >> because most regexp in Emacs packages are well tested and contains no >> nested repetitions. >=20 > Is that an attempt at humor? >=20 >=20 > Stefan >=20 >=20 > --- orig/lisp/isearch.el > +++ mod/lisp/isearch.el > @@ -2480,10 +2480,10 @@ >=20 > ;; non-zero-length match > (let ((ov (make-overlay mb me))) > + (push ov isearch-lazy-highlight-overlays) > (overlay-put ov 'face > isearch-lazy-highlight-face) (overlay-put ov > 'priority 0) ;lower than main overlay=20 > - (overlay-put ov 'window (selected-window)) > - (push ov isearch-lazy-highlight-overlays))) > + (overlay-put ov 'window (selected-window)))) > (if isearch-forward > (setq isearch-lazy-highlight-end (point)) > (setq isearch-lazy-highlight-start (point))))) >=20 >=20 > _______________________________________________ > Emacs-devel mailing list > Emacs-devel@gnu.org > http://lists.gnu.org/mailman/listinfo/emacs-devel