From: Adrian Robert <adrian.b.robert@gmail.com>
To: David Reitter <david.reitter@gmail.com>
Cc: 2530@emacsbugs.donarmstrong.com,
Chong Yidong <cyd@stupidchicken.com>, Ian Eure <ian@digg.com>,
Emacs-Devel devel <emacs-devel@gnu.org>
Subject: Re: 23/NS: redraws according to mouse-face are slow
Date: Tue, 5 May 2009 17:36:31 +0700 [thread overview]
Message-ID: <1ACB40A8-4422-4B9A-A0F7-FE0B9C738299@gmail.com> (raw)
In-Reply-To: <2E6E5869-2F70-4AF5-A917-7EA863D6BD42@gmail.com>
On May 5, 2009, at 10:37 AM, David Reitter wrote:
> On May 4, 2009, at 9:53 PM, Chong Yidong wrote:
>
>> I see. It seems ns_draw_glyph_string is a lot more expensive that
>> x_draw_glyph_string. The show_mouse_face function assumes that the
>> *_draw_glyph_string operation is relatively cheap, which is why it's
>> called inside a loop.
>>
>> My guess is that the problem lies in the calls to ns_focus and
>> ns_unfocus in ns_draw_glyph_string.
>
> Right - but we still need them, at least for clipping.
> That said, because of the clipping, calls to ns_focus may be more
> expensive than desirable. We have multiple calls to
> ns_draw_glyph_string, often more than one for each row, but we only
> need one clipping for the whole frame. So, ideally we'd call
> ns_focus outside the loops that call ns_draw_glyph_string, but the
> architecture won't allow that.
>
>>> If we wrap the code in show_mouse_face in NS[Dis|En]ableScreen, the
>>> problem goes away for me (and it's not just delayed). Same for the
>>> header-line/overlay issues I reported in #2530.
>>
>> If possible, we should minimize the amount of platform-dependent code
>> inside xdisp.c. Could you experiment with putting these calls
>> somewhere
>> in nsterm.m, say surrounding the calls to note_mouse_highlight?
>>
>> Also, could it be ns_update_begin and ns_update_end that you want to
>> call, instead of NSDisableScreen and NSEnableScreen?
>
> Yes, sure, this variant works well, and it takes care of the ugly
> flicker as well.
> (However, when moving the mouse over a piece of text with (common)
> mouse-face property, we shouldn't need to redraw in the first
> place, and that should be addressed at some point, perhaps after
> 23.1.)
That ns_update_begin() acheives the same effect suggests that perhaps
the core mouse face code should do this (through the RIF).
ns_draw_glyph_string() is not slow for any other operations, despite
the fact that it is called with the same granularity (same-face-glyph-
run) everywhere, likely because the update_begin()/end() batching is
used.
(And yes, thanks for tracking this David!)
-Adrian
next prev parent reply other threads:[~2009-05-05 10:36 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <BAF3A3D5-641B-45BA-9DA1-DC767D2D9ECE@gmail.com>
2009-04-20 18:01 ` 23/NS: redraws according to mouse-face are slow David Reitter
2009-04-24 3:27 ` Adrian Robert
2009-05-04 22:55 ` David Reitter
2009-05-04 23:24 ` Leo
2009-05-05 1:53 ` Chong Yidong
2009-05-05 3:37 ` David Reitter
2009-05-05 10:36 ` Adrian Robert [this message]
2009-05-05 14:13 ` Chong Yidong
2009-05-05 17:32 ` David Reitter
2016-01-14 5:08 ` bug#2530: " Andrew Hyatt
2016-01-14 20:34 ` Alan J Third
2016-01-14 21:00 ` David Reitter
2016-01-14 21:39 ` Christian Kruse
2016-01-15 7:38 ` Eli Zaretskii
2016-01-16 4:15 ` Andrew Hyatt
2009-05-06 1:47 ` Stefan Monnier
2009-05-06 7:40 ` YAMAMOTO Mitsuharu
2009-05-06 0:50 ` YAMAMOTO Mitsuharu
2009-05-06 1:55 ` Adrian Robert
2009-05-06 2:25 ` YAMAMOTO Mitsuharu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ACB40A8-4422-4B9A-A0F7-FE0B9C738299@gmail.com \
--to=adrian.b.robert@gmail.com \
--cc=2530@emacsbugs.donarmstrong.com \
--cc=cyd@stupidchicken.com \
--cc=david.reitter@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=ian@digg.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).