From: Dmitry Gutov <dmitry@gutov.dev>
To: tomas@tuxteam.de
Cc: Spencer Baugh <sbaugh@janestreet.com>, emacs-devel@gnu.org
Subject: Re: Releasing the thread global_lock from the module API
Date: Sat, 2 Mar 2024 17:35:26 +0200 [thread overview]
Message-ID: <19d51eaa-0f98-4542-9d08-0e9d23224dc4@gutov.dev> (raw)
In-Reply-To: <ZeK/rElGaAuUNeEE@tuxteam.de>
On 02/03/2024 07:57, tomas@tuxteam.de wrote:
> On Sat, Mar 02, 2024 at 01:53:05AM +0200, Dmitry Gutov wrote:
>> On 01/03/2024 21:30, tomas@tuxteam.de wrote:
>>>> - Unrelated Lisp thread B is able to take the global lock and run Lisp code
>>>> in parallel with module_work on thread A.
>>>> - On thread A, module_work finishes and returns to Lisp.
>>> Why has thread A wait up to here? This is what's keeping your thread B
>>> from playing, no?
>>
>> I imagine thread A will want to continue its execution when the results of
>> the "Emacs-independent work" arrive.
>
> In that case, I think your only choice would be to "pass the continuation":
> in A, stash away whatever you need to continue, let A die, and when things
> "come back", start a thread A' to pick up where A left.
Almost, except "suspend/yield" instead of "let A die".
And if the Lisp threads are backed by OS threads, such thread is waiting
without purpose while "suspended" - Spencer's suggestion could put it to
work in the meantime as well. Though the difference in performance might
not be very significant, given our overhead in other places.
>> Said work might look like making a network request (as Spencer outlined),
>> getting a response, parsing the received JSON structure (not into Lisp
>> objects yet, just into the native data structures provided by the library),
>> and potentially filtering the parsed structure as well.
>>
>> Then the lock is re-acquired (which will naturally involve some spinning
>> waiting for it), and the parsed data is converted into Lisp structures.
>
> I'm always wary when people call for "threads" when they mean concurrency.
Yes, our Lisp threads are a bit unusual, terminology-wise.
next prev parent reply other threads:[~2024-03-02 15:35 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-01 14:53 Releasing the thread global_lock from the module API Spencer Baugh
2024-03-01 16:47 ` Eli Zaretskii
2024-03-01 17:34 ` Spencer Baugh
2024-03-01 18:44 ` Eli Zaretskii
2024-03-01 19:02 ` Spencer Baugh
2024-03-01 19:26 ` Eli Zaretskii
2024-03-01 19:51 ` Spencer Baugh
2024-03-01 20:42 ` Eli Zaretskii
2024-03-01 21:21 ` Spencer Baugh
2024-03-01 21:34 ` Eli Zaretskii
2024-03-01 21:56 ` Spencer Baugh
2024-03-02 6:43 ` Eli Zaretskii
2024-03-02 16:39 ` sbaugh
2024-03-02 17:02 ` Eli Zaretskii
2024-03-02 20:33 ` Spencer Baugh
2024-03-03 6:13 ` Eli Zaretskii
2024-03-03 13:19 ` sbaugh
2024-03-03 15:42 ` Dmitry Gutov
2024-03-03 15:51 ` Eli Zaretskii
2024-03-01 19:30 ` tomas
2024-03-01 23:53 ` Dmitry Gutov
2024-03-02 5:57 ` tomas
2024-03-02 15:35 ` Dmitry Gutov [this message]
2024-03-02 16:31 ` tomas
2024-03-02 21:41 ` sbaugh
2024-03-03 6:25 ` tomas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19d51eaa-0f98-4542-9d08-0e9d23224dc4@gutov.dev \
--to=dmitry@gutov.dev \
--cc=emacs-devel@gnu.org \
--cc=sbaugh@janestreet.com \
--cc=tomas@tuxteam.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).