From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Bob Rogers Newsgroups: gmane.emacs.devel Subject: Re: Updating *vc-dir* marks from *VC-log* Date: Sun, 21 Nov 2010 15:46:05 -0500 Message-ID: <19689.34061.22358.70758@rgr.rgrjr.com> References: <19688.28312.768696.349949@rgr.rgrjr.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1290372391 5587 80.91.229.12 (21 Nov 2010 20:46:31 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 21 Nov 2010 20:46:31 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Nov 21 21:46:24 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PKGne-0004eE-J2 for ged-emacs-devel@m.gmane.org; Sun, 21 Nov 2010 21:46:14 +0100 Original-Received: from localhost ([127.0.0.1]:58666 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PKGne-00033m-1W for ged-emacs-devel@m.gmane.org; Sun, 21 Nov 2010 15:46:14 -0500 Original-Received: from [140.186.70.92] (port=44690 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PKGnZ-00033U-4y for emacs-devel@gnu.org; Sun, 21 Nov 2010 15:46:10 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PKGnY-0000Jc-4o for emacs-devel@gnu.org; Sun, 21 Nov 2010 15:46:09 -0500 Original-Received: from rgrjr.com ([216.146.47.5]:54526) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PKGnY-0000JM-0S for emacs-devel@gnu.org; Sun, 21 Nov 2010 15:46:08 -0500 Original-Received: from rgrjr.dyndns.org (c-66-30-196-77.hsd1.ma.comcast.net [66.30.196.77]) by rgrjr.com (Postfix on CentOS) with ESMTP id 2D9B1160129 for ; Sun, 21 Nov 2010 20:46:06 +0000 (UTC) Original-Received: (qmail 18958 invoked by uid 89); 21 Nov 2010 20:46:05 -0000 Original-Received: from unknown (HELO rgr.rgrjr.com) (192.168.57.1) by home with SMTP; 21 Nov 2010 20:46:05 -0000 Original-Received: by rgr.rgrjr.com (Postfix, from userid 500) id 4A4E6A4E6E; Sun, 21 Nov 2010 15:46:05 -0500 (EST) In-Reply-To: X-Mailer: VM 7.19 under Emacs 24.0.50.1 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:132986 Archived-At: From: Stefan Monnier Date: Sun, 21 Nov 2010 13:43:19 -0500 > Perhaps I'm slow, but I only just noticed that it is possible to work > on multiple VC commits for the same working copy in parallel, just by > renaming *VC-log* buffers. This is cool; it perfectly suits my working > style. I would like to write it up for the Emacs manual so that others > can find it. Hmm... I'd like to change VC-Log so that it always commits what's selected in vc-dir at the time of the commit rather than at the time the VC-Log buffer is opened (with a confirmation prompt to the user when the two sets are actually different). Yes, that's what I thought you meant. (But I was thinking of going further, such that if the user refuses the "Use new fileset?" prompt, there is a followup "Commit current fileset?" prompt. That preserves access to existing behavior, though it does make an exception to the "always commits" rule you have stated.) In the common case where the user only uses a single VC-Log buffer, it is better than the current situation since it makes your log-edit-visit-files-in-vc-dir completely unnecessary. That is mostly true. The difference is that log-edit-visit-files-in-vc-dir also works to change the fileset of a commit that starts from a single file. You can use vc-dir for that purpose by doing an explicit C-x v v in *vc-dir* to hijack the existing single-file log buffer, but that is not obvious. And if the user doesn't C-x v v from *vc-dir*, then C-c C-c won't DTRT, because it won't know about *vc-dir*. And it would also be convenient to have a log-edit-mode command that takes you back to the right *vc-dir* buffer. Of course, that's a much simpler command than log-edit-visit-files-in-vc-dir. Would that be preferable? But I'm not sure how to best handle your use case where you have several VC-Log buffers, then. Stefan Then perhaps we should table this discussion until the "Use new fileset?" prompt is in place. -- Bob