From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: discoverability, better defaults and which-key in Emacs Date: Thu, 8 Feb 2024 15:41:52 +0200 Message-ID: <19622bd6-0ce2-4ab4-b633-ea744740bc53@gutov.dev> References: <874jetaxri.fsf@jeremybryant.net> <87le84oqbd.fsf@yahoo.com> <87plxdpsxw.fsf@posteo.net> <87r0hridvr.fsf@posteo.net> <5dd3d04c-c0eb-43fe-b7c2-957f80261ea3@gutov.dev> <87eddqiw84.fsf@posteo.net> <32071337-c91d-46ad-bb9b-10b8d0c83965@gutov.dev> <86h6ikzc38.fsf@gnu.org> <1056a72d-af5c-487e-be33-67522fe47d17@gutov.dev> <87r0hnohgv.fsf@gmail.com> <86a5obxwy9.fsf@gnu.org> <61ffccc8-56c0-4b14-9420-2d0fd9cac216@gutov.dev> <86r0hnw1l1.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33914"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: visuweshm@gmail.com, justin@burkett.cc, philipk@posteo.net, luangruo@yahoo.com, jb@jeremybryant.net, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Feb 08 14:42:51 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rY4fy-0008ZX-9M for ged-emacs-devel@m.gmane-mx.org; Thu, 08 Feb 2024 14:42:51 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rY4fG-0004G5-10; Thu, 08 Feb 2024 08:42:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rY4fB-0004Fl-Mv for emacs-devel@gnu.org; Thu, 08 Feb 2024 08:42:01 -0500 Original-Received: from wout5-smtp.messagingengine.com ([64.147.123.21]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rY4f9-0006gY-4F; Thu, 08 Feb 2024 08:42:01 -0500 Original-Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 011453200A14; Thu, 8 Feb 2024 08:41:55 -0500 (EST) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Thu, 08 Feb 2024 08:41:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1707399715; x=1707486115; bh=OX6BoDVREYU4V3FvfIRzsGZXAsFAwmwtC+9RWEXdgN4=; b= dpJTdL3BltjSu93tmY5KMe5fV+bTJEOBjkSQ8emN9l2ujuUMPTPozHRlec4J+3we 8brWfqN6qWn8PThDOvaSyn/yuLidgSr/cIuyHPXjn9ETtd85eKVfWr+dXwnz9Nye G4H8RErZ+1p1BFpbEJOwBfD5NUe/Dj/ObTvQy3w4zRLrWxc8VTcAQjLIm8rxwYkR gEjnh8akrmSaLvZqQcmNQ1yD1u8B9jJo9bRIoZItRFOFPMhB9TGe1u5jCH4gwbnj ujBfygArOr0ufs4kUaYB9ogsUXr2zlz0NfPAgiQ+Y1BaSpS1PxWGCtYH8LeIcCQM RMgZNW5Ju5vZpgq0OzM2Dw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1707399715; x= 1707486115; bh=OX6BoDVREYU4V3FvfIRzsGZXAsFAwmwtC+9RWEXdgN4=; b=L tzJ2HzbNfByhkenJPJEkCvH35IQqI8DOTFLypRg87xjPf2ftT1n6hzUawR+sI62O xTa08RltQ5L19cc9wkhiLQLWMYCPmQm7IgaNFinxTh6QOS/ikRcGH/m5eDFGfckV oqHYrS7+fu86Xi73DUsmsEt8+HYGxV6uTzpnGVdRtQlK8NHkKS+eRoE9O9vLwcMR QHrPq0AzWCd73jP6M5JnoIFo/CdbDuOvIE65R9LfU8uFKzQt1Nvw/cmhAxqMj2Nn R7YoYf/rLXGVheHHk2ERONJZUhNYGqLgphXLP811PbKiEYtbd8fDGLBLSS2fovKZ 3swWcO0cPMHIx2rFwFrAA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrtdeggdehfecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfg hrlhcuvffnffculdeimdenucfjughrpefkffggfgfuvfevfhfhjggtgfesthejredttddv jeenucfhrhhomhepffhmihhtrhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrd guvghvqeenucggtffrrghtthgvrhhnpeetudeljeegheetgfehgeejkeeuhedvveeikeeu fedtvddtveefhfdvveegudejheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmh epmhgrihhlfhhrohhmpegumhhithhrhiesghhuthhovhdruggvvh X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 8 Feb 2024 08:41:53 -0500 (EST) Content-Language: en-US In-Reply-To: <86r0hnw1l1.fsf@gnu.org> Received-SPF: pass client-ip=64.147.123.21; envelope-from=dmitry@gutov.dev; helo=wout5-smtp.messagingengine.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_SBL_A=0.1 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:316032 Archived-At: On 08/02/2024 15:02, Eli Zaretskii wrote: >> Date: Thu, 8 Feb 2024 14:18:34 +0200 >> Cc: justin@burkett.cc, philipk@posteo.net, luangruo@yahoo.com, >> jb@jeremybryant.net, emacs-devel@gnu.org >> From: Dmitry Gutov >> >> On 08/02/2024 08:59, Eli Zaretskii wrote: >>> But >>> I added F1 to that text, which should help if someone did change >>> help-char. >> >> Whether help-char is changed, or 'C-h' is rebound anyway, can all be >> detected at runtime. can also have a different binding in the >> current prefix map--then the new message would be doubly incorrect. > > How frequently do people rebind F1? IME, never. Sure, likewise with C-h. That's why the original patch was probably okay as-is. > But I don't object to adding runtime detection of the help keys. Good. >> I'd rather we picked one (preferably correct) suggestion and printed that. > > Most people will never rebind C-h. Those who do could rebind it to a > character that cannot be used in this situation because it is already > bound in various prefix maps. Having two alternatives there increases > the probability that one of them will work. If we consider the situations where C-h or f1 is rebound, having misleading text in the message (with bindings that don't work) should concern us as well. Even if one of the suggestions is likely to work anyway (while the other doesn't). >> For context: I customize echo-keystrokes to a very low value and >> currently see this help message quite often. > > If the message annoys you, you can disable it. Sure - this is not a deal-breaker. But the more features I disable the less problems I could find while dogfooding. Until now I've been running with it, and it seemed unobtrusive enough. Runtime detection might even make it occasionally helpful in odd contexts where something shadows the binding.