From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.devel Subject: Re: How to add pseudo vector types Date: Wed, 28 Jul 2021 12:36:33 -0400 Message-ID: <18D745F5-DBB1-46CC-91D3-4ADAA9D37AB9@gmail.com> References: <83h7gw6pyj.fsf@gnu.org> <46BBFF88-76C3-4818-8805-5437409BEA93@gmail.com> <83wnpq46uk.fsf@gnu.org> <533BD53B-4E85-4E9E-B46A-346A5BBAD0F5@gmail.com> <258CB68D-1CC1-42C8-BDCD-2A8A8099B783@gmail.com> <1a776770-50b7-93cd-6591-c9a5b3a56eb8@gmail.com> <8335s64v10.fsf@gnu.org> <5380C92B-6C15-4490-A1E0-1C3132DBB16A@gmail.com> <83k0li2shw.fsf@gnu.org> <86wnpg82v3.fsf@stephe-leake.org> <83lf5wyn0z.fsf@gnu.org> <86pmv66yqg.fsf@stephe-leake.org> <83a6maw705.fsf@gnu.org> <83r1fluikh.fsf@gnu.org> <88007ACB-31E5-440F-876D-9F43C8EE02CC@gmail.com> <86fsw05lom.fsf@stephe-leake.org> <8A3823DD-5D5A-4A33-8EF9-93F05497CE4C@gmail.com> <864kcf5cmv.fsf_-_@stephe-leake.org> Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.60.0.2.21\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39868"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , =?utf-8?Q?Cl=C3=A9ment_Pit-Claudel?= , monnier@iro.umontreal.ca, emacs-devel To: Stephen Leake Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Jul 28 18:37:19 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m8mYY-000AAx-Hm for ged-emacs-devel@m.gmane-mx.org; Wed, 28 Jul 2021 18:37:18 +0200 Original-Received: from localhost ([::1]:55526 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m8mYX-0001cc-K6 for ged-emacs-devel@m.gmane-mx.org; Wed, 28 Jul 2021 12:37:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33290) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m8mXv-0000uc-NV for emacs-devel@gnu.org; Wed, 28 Jul 2021 12:36:39 -0400 Original-Received: from mail-qt1-x82f.google.com ([2607:f8b0:4864:20::82f]:39546) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m8mXt-0004NK-3K; Wed, 28 Jul 2021 12:36:39 -0400 Original-Received: by mail-qt1-x82f.google.com with SMTP id d2so1781233qto.6; Wed, 28 Jul 2021 09:36:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=T1NOmZTgD0nkllJHTAHngZk3dhwR4CTifvpYfng/PdY=; b=LZTcIEZ5+t/k4doe9q4Nb7dqKeqOYPZlZ6C/pvL0zzCMdCWrFPzCAwbeGfxmbbcLAH attPRhmVM/5VcbZTN+mSdnYG9mB6q1guUcC+m3JOnTaNPZ5DiS3mjA/CqN7qG8sqqeo+ /blNhXQOwlohYepni7S1+nZrzMgznmNnkyaMq3MVY8B6DDxvIVeCiWHAifMG4UVX5MTQ x1acTdscdPirqUtWcJ5bXYYRsuRGE3GwxcPrinlNNkay71+pQdgdzhg3Ed2CK72xqS4M 0yhphhxdoEqTLswgwsolsNF8FCiqJKpI3dAJunZjfo9WpHKL6aUmdkQRd5HGbbwKLEwA ExRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=T1NOmZTgD0nkllJHTAHngZk3dhwR4CTifvpYfng/PdY=; b=Q8UlqUTNShKXShQ69VcZ4+3/QwiDh0/16NcNKaPfaom7q30nlDKbn+eDyR7MXclXE7 mT6IqSsOpJ2Z3KaIa/OvyCyv6J3e0Zd893/LUG0x4P9GvrChsduNekKw2TXoiUclEkjR z6W7pgoDZl8M7ZLB4JgMMEMhZDZOffqYlTekaF5FUilkWMMpHiGTvoX5KC3g9ZhgJn/0 AxRzDdbiIfFgUevPS84Wvbmhi6nbq0ilHtR157alfewDrHIeM8h3gfkdswaSvcV6DGVV O2Mle/1YRbgACRGhf6DNCowcDoNjQqugPmr3NUpM8X/9hx0zSglDB2Q+ctb4w23Dmtgc xR7g== X-Gm-Message-State: AOAM533GLjQZVyoUv61gwzk3zSoUPPLmUHShGoHr9BgZZw/JMizO4IMI cKxoZF2iZWc49pPbCHdK9pI= X-Google-Smtp-Source: ABdhPJxGnnCud9ffwh9TUfAW06gAeF5nFQG8IzJsfax97EMfiJwddUx6iuvifPDy9V7HFmM6cSoZDw== X-Received: by 2002:ac8:d4a:: with SMTP id r10mr354719qti.245.1627490195305; Wed, 28 Jul 2021 09:36:35 -0700 (PDT) Original-Received: from 2603-7080-0302-635e-540d-2222-3fe9-1314.res6.spectrum.com (2603-7080-0302-635e-540d-2222-3fe9-1314.res6.spectrum.com. [2603:7080:302:635e:540d:2222:3fe9:1314]) by smtp.gmail.com with ESMTPSA id g24sm140140qtr.86.2021.07.28.09.36.34 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 28 Jul 2021 09:36:34 -0700 (PDT) In-Reply-To: <864kcf5cmv.fsf_-_@stephe-leake.org> X-Mailer: Apple Mail (2.3654.60.0.2.21) Received-SPF: pass client-ip=2607:f8b0:4864:20::82f; envelope-from=casouri@gmail.com; helo=mail-qt1-x82f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:271768 Archived-At: > On Jul 27, 2021, at 11:40 PM, Stephen Leake = wrote: >=20 > Yuan Fu writes: >=20 >>>>=20 >>>> We need to =E2=80=9Cdelete=E2=80=9D the hidden text and = =E2=80=9Cre-insert=E2=80=9D when we widen the >>>> buffer. I=E2=80=99ll try to make it a no-op as long as we remember = to widen >>>> before calling tree-sitter to parse anything. >>>=20 >>> First, the only thing TS deletes is tree nodes, not text; it does = not >>> have a copy of the buffer. >>>=20 >>> Why do you think we need to delete the tree nodes corresponding to = the >>> hidden text? They provide exactly the context needed to parse the >>> visible text properly. >>=20 >> I don=E2=80=99t think we need to, but I assume that tree-sitter will = delete >> the corresponding nodes if we hide the text from it.=20 >=20 > No, tree-sitter only deletes nodes that cover changes. >=20 > So don't send a change that deletes the hidden text; just send changes > in the visible part of the text (that's the only place the user can = make > changes). tree-sitter will only run the scanner on the change regions, > so it will only request text from the visible part of the buffer; > all the requests will succeed. Then we are not hiding the hidden text from tree-sitter. The = implementation you described, IIUC, is essentially do nothing special = when the buffer is narrowed.=20 >=20 >> For us, the text is there, just hidden; for tree-sitter, the text is >> deleted. >=20 > No, it simply won't notice that it can't access that part of the = buffer, > because it will never try. >=20 > What, exactly, will the buffer-text fetch code do if tree-sitter > violates the narrowing (by some error in tree-sitter or user code)? > throw an exception? return a null string? In my current implementation, if tree-sitter access buffer content = outside of narrowed region, it reads whitespaces, if it access buffer = content outside of the buffer, it reads null string. Neither case throws = an error. Yuan