From: nickrob@snap.net.nz (Nick Roberts)
To: Chong Yidong <cyd@stupidchicken.com>
Cc: Eli Zaretskii <eliz@gnu.org>,
Stefan Monnier <monnier@iro.umontreal.ca>,
emacs-devel@gnu.org
Subject: Re: tooltip-mode shouldn't be enabled in the Linux console by default
Date: Wed, 29 Apr 2009 19:22:53 +1200 [thread overview]
Message-ID: <18936.77.199125.394794@totara.tehura.co.nz> (raw)
In-Reply-To: <87tz48zyb1.fsf@cyd.mit.edu>
> > This looks to me like an ugly hack that subverts the purpose of
> > tooltip-show-help-non-mode. I tried the patch below (against 1.93,
> > the version before your checkin) but the help message seems to persist
> > after the mouse has moved away from the mouse-highlight region.
>
> Yes, and if you fix that bug, you end up with a function that looks like
> tooltip-show-help-non-mode, pretty much. So it's better to use
> tooltip-show-help-non-mode in the first place.
I don't follow that logic as I don't currently understand why the help message
persists with my patch.
Addressing Eli's question, it just seems convoluted to have two
help-functions, select one and then, under certain conditions, get it to call
the other - a bit like a double negative.
Clearly though, my criticism isn't really valid unless I can come up with
a better patch - which I will try to do.
--
Nick http://www.inet.net.nz/~nickrob
prev parent reply other threads:[~2009-04-29 7:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-26 11:04 tooltip-mode shouldn't be enabled in the Linux console by default Nick Roberts
2009-04-26 17:43 ` Eli Zaretskii
2009-04-26 18:24 ` Glenn Morris
2009-04-27 4:00 ` Stefan Monnier
2009-04-27 18:47 ` Eli Zaretskii
2009-04-28 2:18 ` Chong Yidong
2009-04-28 7:57 ` Nick Roberts
2009-04-28 8:36 ` Eli Zaretskii
2009-04-28 13:45 ` Chong Yidong
2009-04-29 7:22 ` Nick Roberts [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18936.77.199125.394794@totara.tehura.co.nz \
--to=nickrob@snap.net.nz \
--cc=cyd@stupidchicken.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).