From: Nick Roberts <nickrob@snap.net.nz>
To: emacs-devel@gnu.org
Subject: Re: vc-svn-after-dir-status
Date: Tue, 10 Feb 2009 19:13:57 +1300 [thread overview]
Message-ID: <18833.6949.191366.472622@kahikatea.snap.net.nz> (raw)
In-Reply-To: <18826.37134.246157.940138@kahikatea.snap.net.nz>
> I think the patch below fixes it but couldn't test it as I encountered bugs
> which stopped vc-dir from working. These were in vc-dir-update in
> vc-dir.el, and occurred because prev-node in (vc-dir-node-directory
> prev-node) was nil when files needed updating and expand-file-name somwhere
> had a nil argument when there were no files that needed updating. >
>...
> --- vc-svn.el.~1.111.~ 2009-02-05 09:37:04.000000000 +1300
> +++ vc-svn.el 2009-02-05 12:23:41.000000000 +1300
> @@ -164,7 +164,7 @@ want to force an empty list of arguments
> (?? . unregistered)
> ;; This is what vc-svn-parse-status does.
> (?~ . edited)))
> - (re (if remote "^\\(.\\)..... \\([ *]\\) +[-0-9]+ +\\(.*\\)$"
> + (re (if remote "^\\(.\\)..... \\([ *]\\) +\\(:?[-0-9]+\\)? +\\(.*\\)$"
That should have been:
> + (re (if remote "^\\(.\\)..... \\([ *]\\) +\\(?:[-0-9]+\\)? +\\(.*\\)$"
which was why I was seeing errors. I've committed this corrected change.
--
Nick http://www.inet.net.nz/~nickrob
prev parent reply other threads:[~2009-02-10 6:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-05 7:11 vc-svn-after-dir-status Nick Roberts
2009-02-10 6:13 ` Nick Roberts [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18833.6949.191366.472622@kahikatea.snap.net.nz \
--to=nickrob@snap.net.nz \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).