unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Nick Roberts <nickrob@snap.net.nz>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Dan Nicolaescu <dann@ics.uci.edu>, emacs-devel@gnu.org
Subject: Re: vc-svn-dir-status
Date: Fri, 6 Feb 2009 17:42:00 +1300	[thread overview]
Message-ID: <18827.49048.239652.454180@kahikatea.snap.net.nz> (raw)
In-Reply-To: <jwvy6wp96yi.fsf-monnier+emacs@gnu.org>

 > > In response to bug#2117 I suggested that I suggested that vc-stay-local-p
 > > need not be slow if vc-svn-registered need parsed the SVN controlled
 > > text-base directory instead of executing "svn status -v DIR".
 > 
 > That would be a good change.  Many VC backends do similar things to
 > speed up this common operation.  Tho, admittedly, this is usually done
 > for files rather than for dirs, so there might be unexpected problems.

Maybe the text-base directory is irrelevant but I've tried to understand why
"svn status" gets called twice in this case.  I think in this first case,
vc-local-p -> vc-registered -> vc-svn-registered it just needs the status of
one file, namely the directory, and it needn't recurse.  If that's so "svn
status -v -N DIR" would presumably be quicker and only the first line need be
parsed.  vc-cvs-registered does nothing in the case of a directory argument,
presumably because, in CVS, directories aren't under version control.

To add to my confusion I don't understand the documentation string of
vc-svn-parse-status:

   ...Unless FILENAME is non-nil, parse only information about FILENAME and
   return its status.

It always appears to be non-nil but if it was nil how could you parse
information about it?

-- 
Nick                                           http://www.inet.net.nz/~nickrob




      reply	other threads:[~2009-02-06  4:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-31 23:59 vc-svn-dir-status Nick Roberts
2009-02-01 21:36 ` vc-svn-dir-status Stefan Monnier
2009-02-06  4:42   ` Nick Roberts [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=18827.49048.239652.454180@kahikatea.snap.net.nz \
    --to=nickrob@snap.net.nz \
    --cc=dann@ics.uci.edu \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).