From: Nick Roberts <nickrob@snap.net.nz>
To: Stefan Monnier <monnier@IRO.UMontreal.CA>
Cc: Chong Yidong <cyd@stupidchicken.com>,
Dan Nicolaescu <dann@ics.uci.edu>,
emacs-devel@gnu.org
Subject: Re: VC Development
Date: Thu, 5 Feb 2009 19:54:44 +1300 [thread overview]
Message-ID: <18826.36148.387963.106549@kahikatea.snap.net.nz> (raw)
In-Reply-To: <jwvvdrqngtd.fsf-monnier+emacs@gnu.org>
> That looks OK, yes.
> You may want to wrap the code of vc-dir-find-file-other-window inside
> a save-selected-window since posn-set-point may change the window.
> Also I'd use last-nonmenu-event since that's what is used by
> interactive's "e" code. IIUC that would allow it work if the command is
> put on a contextual pop-up menu.
I've used last-nonmenu-event but trying save-selected-window put the file in
the *vc-dir* buffer if that was not already selected - so I gave up. I think
the window holding the visited file should become the selected window because
that's presumably where the user wants to go. I was trying to get it to work
like dired-mouse-find-file-other-window, which doesn't move the cursor in the
dired window, but I couldn't find a way to get it to work for all cases.
--
Nick http://www.inet.net.nz/~nickrob
next prev parent reply other threads:[~2009-02-05 6:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-31 23:41 VC Development Nick Roberts
2009-02-01 2:25 ` Chong Yidong
2009-02-01 6:02 ` Dan Nicolaescu
2009-02-01 8:16 ` Nick Roberts
2009-02-01 14:25 ` Chong Yidong
2009-02-01 19:47 ` Nick Roberts
2009-02-01 21:33 ` Stefan Monnier
2009-02-04 9:34 ` Nick Roberts
2009-02-04 19:31 ` Stefan Monnier
2009-02-05 6:54 ` Nick Roberts [this message]
2009-02-05 21:01 ` Stefan Monnier
2009-02-01 21:22 ` Stefan Monnier
2009-02-02 18:44 ` Dan Nicolaescu
2009-02-02 21:15 ` Stefan Monnier
2009-02-03 7:39 ` Nick Roberts
2009-02-01 2:41 ` Chong Yidong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18826.36148.387963.106549@kahikatea.snap.net.nz \
--to=nickrob@snap.net.nz \
--cc=cyd@stupidchicken.com \
--cc=dann@ics.uci.edu \
--cc=emacs-devel@gnu.org \
--cc=monnier@IRO.UMontreal.CA \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).