From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Saulius Menkevicius Newsgroups: gmane.emacs.devel Subject: Re: master 2c79a8f 2/2: Use posix_spawn if possible. Date: Mon, 7 Feb 2022 23:12:27 +0200 Message-ID: <187BA387-6D96-457A-A157-388AD9379D85@fastmail.com> References: <87czk5brgr.fsf@gmail.com> <7BD6026F-D756-42C3-9FCC-724D9A6B2378@fastmail.com> Mime-Version: 1.0 (Mac OS X Mail 15.0 \(3693.60.0.1.1\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5615"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Alan Third , emacs-devel@gnu.org, p.stephani2@gmail.com, Matt Armstrong , Eli Zaretskii , mituharu@math.s.chiba-u.ac.jp To: Robert Pluim Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Feb 08 04:23:13 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nHH60-0001Ff-0K for ged-emacs-devel@m.gmane-mx.org; Tue, 08 Feb 2022 04:23:13 +0100 Original-Received: from localhost ([::1]:37328 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nHH5y-0007xf-RT for ged-emacs-devel@m.gmane-mx.org; Mon, 07 Feb 2022 22:23:10 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:42218) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nHBJR-0008N5-0K for emacs-devel@gnu.org; Mon, 07 Feb 2022 16:12:41 -0500 Original-Received: from wout5-smtp.messagingengine.com ([64.147.123.21]:56955) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nHBJN-0000oL-Q8; Mon, 07 Feb 2022 16:12:39 -0500 Original-Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 760993201DDC; Mon, 7 Feb 2022 16:12:32 -0500 (EST) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Mon, 07 Feb 2022 16:12:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; bh=Jik4fnc5vRi45M sQxzie+9LfyO67RStGr1a1kTBfMPk=; b=HfJ2hLNwiTWHmTzfhpzHOOX4+kWy0m bEHlIYG7BKBrtG874nNLrgqYIBosy4euyOm4uAG5UVBOBZRERMfCxkMHf6q+i9m5 XK7gNNKk1u2VPfqSL8bAWyDaCKpsJt6CaPHXR3WAj5F73ihv7uy25d9rzl33WD+w BC1iBGFARlZHrT2cBi/zxBsdunqQLj+gcEteB1OzvZCpkCI9WJe5R6Vnpmf4Dc6i MITHc97Hl9uZKs1KDmlxP+eBrCP6dmUaxCMU4LyKqAyG+TCFed7J7bKfLKF+AkNQ sPeuvrIFPb2cmP92e8t0QVl1hMzbJ772MJglgm0/sWoT2eN4VdGhW3Ug== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=Jik4fnc5vRi45MsQxzie+9LfyO67RStGr1a1kTBfM Pk=; b=dLM5wRG42XpMIRiguf0bXzXdPhNlO4f09Wnp0M4SpV0uwKZHCSA4GJfzd fdpFReabl/0wuMQS2AAiVOg6oLRiDNH+feLLMKyM0Uagoj1yrC+HHA9e7aydxWUp R1W7QfUtJx0zpXB7ZrDINI7Vpmh15q8ouxYA37xcHPoSlBWviNNXvKmI2UUXrWa7 nlN9yk4vaWbdXZhOfX3VgOVcYY2JkMbOL6jTX/uDMgXUefzfJgXVaBpSQ5GJ8DXG In1V/4FqcYX5NHyta1HsnxgRK9kCYQwoMHw7OJhmq5jOBUtx2JyMDHO8LXzHPVmH 7KggvT7MlM9pXIN18/zwYMvlN2IXQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrheehgddugeefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurheptggguffhjgffgffkfhfvofesthhqmhdthhdtjeenucfhrhhomhepufgruhhl ihhushcuofgvnhhkvghvihgtihhushcuoehsrghulhhiuhhsmhgvnhhkvghvihgtihhush esfhgrshhtmhgrihhlrdgtohhmqeenucggtffrrghtthgvrhhnpefftdekgfffgedtueek gfeftefgfeeggffggfdufeevueetheeuieetieffgfelvdenucevlhhushhtvghrufhiii gvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehsrghulhhiuhhsmhgvnhhkvghvihgt ihhushesfhgrshhtmhgrihhlrdgtohhm X-ME-Proxy: Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 7 Feb 2022 16:12:30 -0500 (EST) In-Reply-To: <7BD6026F-D756-42C3-9FCC-724D9A6B2378@fastmail.com> X-Mailer: Apple Mail (2.3693.60.0.1.1) Received-SPF: pass client-ip=64.147.123.21; envelope-from=sauliusmenkevicius@fastmail.com; helo=wout5-smtp.messagingengine.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, FREEMAIL_REPLY=1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Mon, 07 Feb 2022 22:21:37 -0500 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:286063 Archived-At: Hello Robert, Eli, I can confirm that this patch is needed for emacs-28 too, as currently = emacs on macOS blocks SIGCHLD the same way as it does on Linux. Applying Robert=E2=80=99s patch on emacs-28 fixes the issue on macOS. Tested on macOS 12.2 / aarch64. -Saulius > Am 2022-02-02 um 10:54 schrieb Saulius Menkevi=C4=8Dius = : >=20 > I=E2=80=99ve just received a new Mac (arm64/M1) for myself so I can = test if 28 has it broken on macOS too. >=20 > =E2=80=94Saulius Menkevi=C4=8Dius >=20 >> Am 2022-02-02 um 10:30 schrieb Robert Pluim : >>=20 >> =EF=BB=BF >>>=20 >>>>>>> On Tue, 01 Feb 2022 21:52:18 +0200, Eli Zaretskii = said: >>=20 >>>> From: Robert Pluim >>>> Cc: Eli Zaretskii , Matt Armstrong , >>>> p.stephani2@gmail.com, alan@idiocy.org, = mituharu@math.s.chiba-u.ac.jp, >>>> emacs-devel@gnu.org >>>> Date: Tue, 01 Feb 2022 20:23:23 +0100 >>>>=20 >>>>>>>>> On Tue, 1 Feb 2022 20:30:18 +0200, Saulius Menkevicius = said: >>>>=20 >> Saulius> Thanks Robert! >> Saulius> I applied your patch and that has actually has fixed the = issue. So I >> Saulius> suggest this patch be applied on master. >>>>=20 >>>> I can do that, if Eli/Lars agree. >>=20 >> Eli> Are there any downsides to the patch? If not, I see no = reasons not to >> Eli> install that. >>=20 >> Not as far as I can tell, but I shall test on a few more platforms >> before pushing. >>=20 >>>> What should we do for emacs-28? >>=20 >> Eli> Nothing, because on emacs-28 we use posix_spawn only on macOS. >>=20 >> Right, I=CA=BCd missed that, master it is then. We could put it in = 28.2, I >> guess, but I hadn't noticed any issues with subprocesses on emacs-28 >> on macOS. >>=20 >> Robert >> --=20