From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ulrich Mueller Newsgroups: gmane.emacs.devel Subject: Re: C-x C-c does nothing on frames created with "nowait" flag Date: Sun, 11 Jan 2009 11:27:36 +0100 Message-ID: <18793.51608.806961.200196@a1ihome1.kph.uni-mainz.de> References: <87r63a430u.fsf@unicorn.lan> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1231669689 26715 80.91.229.12 (11 Jan 2009 10:28:09 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 11 Jan 2009 10:28:09 +0000 (UTC) Cc: emacs-devel@gnu.org To: Bo Lin Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jan 11 11:29:20 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LLxZE-00031s-L9 for ged-emacs-devel@m.gmane.org; Sun, 11 Jan 2009 11:29:16 +0100 Original-Received: from localhost ([127.0.0.1]:56850 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LLxXy-0003ht-95 for ged-emacs-devel@m.gmane.org; Sun, 11 Jan 2009 05:27:58 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LLxXr-0003gX-Ce for emacs-devel@gnu.org; Sun, 11 Jan 2009 05:27:51 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LLxXn-0003dO-Ju for emacs-devel@gnu.org; Sun, 11 Jan 2009 05:27:49 -0500 Original-Received: from [199.232.76.173] (port=58024 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LLxXn-0003dF-E1 for emacs-devel@gnu.org; Sun, 11 Jan 2009 05:27:47 -0500 Original-Received: from a1iwww1.kph.uni-mainz.de ([134.93.134.1]:40224) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LLxXm-0008Cn-UR for emacs-devel@gnu.org; Sun, 11 Jan 2009 05:27:47 -0500 Original-Received: from a1ihome1.kph.uni-mainz.de (a1ihome1.kph.uni-mainz.de [134.93.134.75]) by a1iwww1.kph.uni-mainz.de (8.14.0/8.13.4) with ESMTP id n0BARbcp025028; Sun, 11 Jan 2009 11:27:37 +0100 Original-Received: from a1ihome1.kph.uni-mainz.de (localhost [127.0.0.1]) by a1ihome1.kph.uni-mainz.de (8.14.0/8.14.1) with ESMTP id n0BARbVG008050; Sun, 11 Jan 2009 11:27:37 +0100 Original-Received: (from ulm@localhost) by a1ihome1.kph.uni-mainz.de (8.14.0/8.14.0/Submit) id n0BARbB4008045; Sun, 11 Jan 2009 11:27:37 +0100 In-Reply-To: <87r63a430u.fsf@unicorn.lan> X-Mailer: VM 8.0.2-487 under Emacs 22.2.1 (i686-pc-linux-gnu) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 1) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:107778 Archived-At: >>>>> On Sun, 11 Jan 2009, Bo Lin wrote: > When connecting to a Emacs daemon using "emacsclient -n -c", > pressing C-x C-c in the newly created frame does nothing. It does > not exit Emacs, close the frame, or even give any visible feed-back, > just nothing. That's quite surprising, and at first I thought Emacs > has hanged. I had reported this last month already, but somehow the issue got lost. > I think it should at least give a message, ... or save buffers and delete the frame (also sent the following patch already): --- lisp/files.el.~1.1030.~ +++ lisp/files.el @@ -5733,9 +5733,14 @@ (interactive "P") (let ((proc (frame-parameter (selected-frame) 'client)) (frame (selected-frame))) - (if (null proc) - (save-buffers-kill-emacs) - (server-save-buffers-kill-terminal proc arg)))) + (cond + ((null proc) + (save-buffers-kill-emacs)) + ((processp proc) + (server-save-buffers-kill-terminal proc arg)) + (t + (save-some-buffers arg t) + (delete-frame))))) ;; We use /: as a prefix to "quote" a file name Ulrich