unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Ulrich Mueller <ulm@gentoo.org>
To: Bo Lin <lbsmtp@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: C-x C-c does nothing on frames created with "nowait" flag
Date: Sun, 11 Jan 2009 11:27:36 +0100	[thread overview]
Message-ID: <18793.51608.806961.200196@a1ihome1.kph.uni-mainz.de> (raw)
In-Reply-To: <87r63a430u.fsf@unicorn.lan>

>>>>> On Sun, 11 Jan 2009, Bo Lin wrote:

> When connecting to a Emacs daemon using "emacsclient -n -c",
> pressing C-x C-c in the newly created frame does nothing. It does
> not exit Emacs, close the frame, or even give any visible feed-back,
> just nothing. That's quite surprising, and at first I thought Emacs
> has hanged.

I had reported this last month already, but somehow the issue got lost.
<http://lists.gnu.org/archive/html/emacs-devel/2008-12/msg01095.html>

> I think it should at least give a message,

... or save buffers and delete the frame (also sent the following
patch already):

--- lisp/files.el.~1.1030.~
+++ lisp/files.el
@@ -5733,9 +5733,14 @@
   (interactive "P")
   (let ((proc (frame-parameter (selected-frame) 'client))
 	(frame (selected-frame)))
-    (if (null proc)
-	(save-buffers-kill-emacs)
-      (server-save-buffers-kill-terminal proc arg))))
+    (cond
+     ((null proc)
+      (save-buffers-kill-emacs))
+     ((processp proc)
+      (server-save-buffers-kill-terminal proc arg))
+     (t
+      (save-some-buffers arg t)
+      (delete-frame)))))
 
 \f
 ;; We use /: as a prefix to "quote" a file name

Ulrich




  reply	other threads:[~2009-01-11 10:27 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-11  9:15 C-x C-c does nothing on frames created with "nowait" flag Bo Lin
2009-01-11 10:27 ` Ulrich Mueller [this message]
2009-01-11 11:32   ` Bo Lin
2009-01-11 13:25   ` Chong Yidong
2009-01-11 13:40     ` Ulrich Mueller
2009-01-11 13:58       ` Bo Lin
2009-01-11 14:54   ` Stefan Monnier
2009-01-11 15:57     ` Chong Yidong
2009-01-11 17:38       ` Ulrich Mueller
2009-01-11 20:56         ` Chong Yidong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=18793.51608.806961.200196@a1ihome1.kph.uni-mainz.de \
    --to=ulm@gentoo.org \
    --cc=emacs-devel@gnu.org \
    --cc=lbsmtp@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).