unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Recent change in tramp.el makes byte-compilation fail
@ 2008-12-09 16:46 Ulrich Mueller
  2008-12-09 17:07 ` Ulrich Mueller
  0 siblings, 1 reply; 2+ messages in thread
From: Ulrich Mueller @ 2008-12-09 16:46 UTC (permalink / raw)
  To: Michael Albinus; +Cc: Stelian Ionescu, emacs, emacs-devel

Hi Michael,

looks like the following change:

   2008-12-04  Michael Albinus  <michael.albinus@gmx.de>

	* net/tramp.el (top): Write a message, when loading Tramp.

makes byte-compilation of files that require tramp fail.
To reproduce:

   $ cat test.el
   (require 'tramp)
   $ emacs -batch -q --no-site-file -f batch-byte-compile test.el
   Loading tramp...

   In toplevel form:
   test.el:1:1:Error: Wrong type argument: stringp, nil
   $ 

Ulrich




^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Recent change in tramp.el makes byte-compilation fail
  2008-12-09 16:46 Recent change in tramp.el makes byte-compilation fail Ulrich Mueller
@ 2008-12-09 17:07 ` Ulrich Mueller
  0 siblings, 0 replies; 2+ messages in thread
From: Ulrich Mueller @ 2008-12-09 17:07 UTC (permalink / raw)
  To: Michael Albinus; +Cc: Stelian Ionescu, emacs, emacs-devel

> looks like the following change:

>    2008-12-04  Michael Albinus  <michael.albinus@gmx.de>

> 	* net/tramp.el (top): Write a message, when loading Tramp.

> makes byte-compilation of files that require tramp fail.

This should fix it:

--- emacs-orig/lisp/net/tramp.el
+++ emacs/lisp/net/tramp.el
@@ -7470,8 +7470,10 @@
       (unload-feature 'tramp 'force)
     (error nil)))
 
-(when (and load-in-progress (string-match "Loading tramp..." (current-message)))
-  (message "Loading tramp...done"))
+(and load-in-progress
+     (current-message)
+     (string-match "Loading tramp..." (current-message))
+     (message "Loading tramp...done"))
 
 (provide 'tramp)
 




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-12-09 17:07 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-12-09 16:46 Recent change in tramp.el makes byte-compilation fail Ulrich Mueller
2008-12-09 17:07 ` Ulrich Mueller

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).