unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* intro-string in byte-compiled files
@ 2008-11-10  8:18 Ulrich Mueller
  2008-11-10 15:02 ` Stefan Monnier
  0 siblings, 1 reply; 4+ messages in thread
From: Ulrich Mueller @ 2008-11-10  8:18 UTC (permalink / raw)
  To: emacs-devel

I wonder if the following code found in all byte-compiled files still
makes sense:

;;; This file uses dynamic docstrings, first added in Emacs 19.29.
(if (and (boundp 'emacs-version)
     (< (aref emacs-version (1- (length emacs-version))) ?A)
      (or (and (boundp 'epoch::version) epoch::version)
           (string-lessp emacs-version "19.29")))
    (error "`simple.el' was compiled for Emacs 19.29 or later"))

Emacs 19.29 was released 13 years ago. It is nice to be backwards
compatible, but as some point such things should be dropped.

Ulrich




^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: intro-string in byte-compiled files
  2008-11-10  8:18 intro-string in byte-compiled files Ulrich Mueller
@ 2008-11-10 15:02 ` Stefan Monnier
  2008-11-14  0:00   ` Glenn Morris
  0 siblings, 1 reply; 4+ messages in thread
From: Stefan Monnier @ 2008-11-10 15:02 UTC (permalink / raw)
  To: Ulrich Mueller; +Cc: emacs-devel

> I wonder if the following code found in all byte-compiled files still
> makes sense:

> ;;; This file uses dynamic docstrings, first added in Emacs 19.29.
> (if (and (boundp 'emacs-version)
>      (< (aref emacs-version (1- (length emacs-version))) ?A)
>       (or (and (boundp 'epoch::version) epoch::version)
>            (string-lessp emacs-version "19.29")))
>     (error "`simple.el' was compiled for Emacs 19.29 or later"))

> Emacs 19.29 was released 13 years ago. It is nice to be backwards
> compatible, but as some point such things should be dropped.

Indeed, this should be dropped: our byte-compiled files won't even work
in Emacs-22 anyway.


        Stefan





^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: intro-string in byte-compiled files
  2008-11-10 15:02 ` Stefan Monnier
@ 2008-11-14  0:00   ` Glenn Morris
  2008-11-14  0:51     ` Glenn Morris
  0 siblings, 1 reply; 4+ messages in thread
From: Glenn Morris @ 2008-11-14  0:00 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: Ulrich Mueller, emacs-devel

Stefan Monnier wrote:

> Indeed, this should be dropped: our byte-compiled files won't even work
> in Emacs-22 anyway.

So should it be removed altogether, or replaced with a test for Emacs > 22?




^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: intro-string in byte-compiled files
  2008-11-14  0:00   ` Glenn Morris
@ 2008-11-14  0:51     ` Glenn Morris
  0 siblings, 0 replies; 4+ messages in thread
From: Glenn Morris @ 2008-11-14  0:51 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: Ulrich Mueller, emacs-devel

Glenn Morris wrote:

>> Indeed, this should be dropped: our byte-compiled files won't even work
>> in Emacs-22 anyway.
>
> So should it be removed altogether, or replaced with a test for Emacs > 22?

Oh, there already is a test for that when appropriate.




^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2008-11-14  0:51 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-11-10  8:18 intro-string in byte-compiled files Ulrich Mueller
2008-11-10 15:02 ` Stefan Monnier
2008-11-14  0:00   ` Glenn Morris
2008-11-14  0:51     ` Glenn Morris

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).