From: Ulrich Mueller <ulm@gentoo.org>
To: Juanma Barranquero <lekktu@gmail.com>
Cc: Diego Petteno <flameeyes@gmail.com>,
emacs-devel@gnu.org, Stefan Monnier <monnier@iro.umontreal.ca>,
emacs@gentoo.org
Subject: Re: emacs client/server mode hardcodes /tmp path
Date: Wed, 29 Oct 2008 10:28:10 +0100 [thread overview]
Message-ID: <18696.11434.978893.578213@a1i15.kph.uni-mainz.de> (raw)
In-Reply-To: <f7ccd24b0810290215xe8f4c3eme301ab59ce93b57c@mail.gmail.com>
>>>>> On Wed, 29 Oct 2008, Juanma Barranquero wrote:
>> + socket_name = alloca (96 + strlen (tmpdir) + strlen (server_name));
>> + sprintf (socket_name, "%s/emacs%d/%s",
>> + tmpdir, (int) geteuid (), server_name);
> There was neither much point in allocating an extra 100 bytes, nor
> in allocating 96 now. The formatted uid is not going to be 88
> characters long.
You really want to optimise this? ;-) If we assume that uid_t will
never have more than 64 bits, then a value of 28 should be sufficient
for the constant.
Ulrich (voting for 42)
next prev parent reply other threads:[~2008-10-29 9:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-06 15:43 emacs client/server mode hardcodes /tmp path Diego 'Flameeyes' Pettenò
2008-03-06 17:48 ` Stefan Monnier
2008-03-06 17:58 ` Diego 'Flameeyes' Pettenò
2008-10-28 13:38 ` Ulrich Mueller
2008-10-28 14:29 ` Stefan Monnier
2008-10-29 7:51 ` Ulrich Mueller
2008-10-29 9:15 ` Juanma Barranquero
2008-10-29 9:28 ` Ulrich Mueller [this message]
2008-10-29 9:37 ` Juanma Barranquero
2008-10-29 14:41 ` Stefan Monnier
2008-10-29 14:55 ` Juanma Barranquero
2008-10-29 15:03 ` Stefan Monnier
2008-10-29 15:12 ` Juanma Barranquero
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18696.11434.978893.578213@a1i15.kph.uni-mainz.de \
--to=ulm@gentoo.org \
--cc=emacs-devel@gnu.org \
--cc=emacs@gentoo.org \
--cc=flameeyes@gmail.com \
--cc=lekktu@gmail.com \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).