From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Bob Rogers Newsgroups: gmane.emacs.devel Subject: Re: etags segfault Date: Mon, 25 Aug 2008 21:58:06 -0400 Message-ID: <18611.25390.457832.78695@rgrjr.rgrjr.dyndns.org> References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1219715994 12740 80.91.229.12 (26 Aug 2008 01:59:54 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 26 Aug 2008 01:59:54 +0000 (UTC) Cc: emacs-devel@gnu.org, Kenichi Handa To: Francesco Potorti` Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Aug 26 04:00:48 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KXnrT-0005Uh-74 for ged-emacs-devel@m.gmane.org; Tue, 26 Aug 2008 04:00:47 +0200 Original-Received: from localhost ([127.0.0.1]:53246 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KXnqU-0005p8-SU for ged-emacs-devel@m.gmane.org; Mon, 25 Aug 2008 21:59:46 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KXnqP-0005nS-FZ for emacs-devel@gnu.org; Mon, 25 Aug 2008 21:59:41 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KXnqO-0005m4-0U for emacs-devel@gnu.org; Mon, 25 Aug 2008 21:59:41 -0400 Original-Received: from [199.232.76.173] (port=50868 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KXnqN-0005lq-Oy for emacs-devel@gnu.org; Mon, 25 Aug 2008 21:59:39 -0400 Original-Received: from modulargenetics.com ([68.236.112.17]:19341 helo=alexandria.modulargenetics.com) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KXnqN-0005QT-CK for emacs-devel@gnu.org; Mon, 25 Aug 2008 21:59:39 -0400 Original-Received: from rgrjr.dyndns.org (c-66-30-196-77.hsd1.ma.comcast.net [66.30.196.77]) by alexandria.modulargenetics.com (Postfix on SuSE Linux) with ESMTP id 43E9062097 for ; Mon, 25 Aug 2008 21:58:07 -0400 (EDT) Original-Received: (qmail 16118 invoked by uid 89); 26 Aug 2008 01:58:06 -0000 Original-Received: from unknown (HELO rgr.rgrjr.dyndns.org) (192.168.57.1) by home with SMTP; 26 Aug 2008 01:58:06 -0000 Original-Received: by rgr.rgrjr.dyndns.org (Postfix, from userid 500) id A288D4B630; Mon, 25 Aug 2008 21:58:06 -0400 (EDT) In-Reply-To: X-Mailer: VM 7.19 under Emacs 23.0.60.1 X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:102970 Archived-At: From: Francesco Potorti` Date: Mon, 25 Aug 2008 09:56:40 +0200 I fixed etags' segfault on the trunk. Sorry, my regression tests did not cover this case. The cure is simply to allocate space in memory rather than using static strings. I did not use the patch below, because if leaves tagfiledir uninitialised in the first case. Good point; thank you for catching that. -- Bob