unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Nick Roberts <nickrob@snap.net.nz>
To: emacs-devel@gnu.org
Subject: Re: vc-set-mode-line-busy-indicator
Date: Tue, 26 Feb 2008 09:25:31 +1300	[thread overview]
Message-ID: <18371.9275.720477.806834@kahikatea.snap.net.nz> (raw)
In-Reply-To: <18370.47294.641890.556694@kahikatea.snap.net.nz>

Nick Roberts writes:
 > 
 > The problem with this message is that it is so long that the bit after
 > ("from filename") doesn't fit in 80 columns.  Also a warning-face isn't
 > really needed because it doesn't provide a wake up call: the user has just
 > entered a command, e.g, vc-diff or vc-print-log, so presumably he's already
 > looking for the output buffer.
 > 
 > I've used the same style as I've used for the GUD buffer.  If text in the
 > mode-line is going to be increasingly fontified, it might be a good idea to
 > have some consistency.

I forgot to ask:

Shall I apply this patch?

 > -- 
 > Nick                                           http://www.inet.net.nz/~nickrob
 > 
 > 
 > *** vc.el.~1.541.~	2008-02-24 08:24:18.000000000 +1300
 > --- vc.el	2008-02-26 01:29:24.000000000 +1300
 > *************** BUF defaults to \"*vc*\", can be a strin
 > *** 1064,1077 ****
 >   
 >   (defun vc-set-mode-line-busy-indicator ()
 >     (setq mode-line-process
 > ! 	;; Deliberate overstatement, but power law respected.
 > ! 	;; (The message is ephemeral, so we make it loud.)  --ttn
 > ! 	(propertize " (incomplete/in progress)"
 > ! 		    'face (if (featurep 'compile)
 > ! 			      ;; ttn's preferred loudness
 > ! 			      'compilation-warning
 > ! 			    ;; suitably available fallback
 > ! 			    font-lock-warning-face)
 >   		    'help-echo
 >   		    "A VC command is in progress in this buffer")))
 >   
 > --- 1064,1071 ----
 >   
 >   (defun vc-set-mode-line-busy-indicator ()
 >     (setq mode-line-process
 > ! 	(propertize " [waiting...]"
 > ! 		    'face 'font-lock-variable-name-face
 >   		    'help-echo
 >   		    "A VC command is in progress in this buffer")))
 >   




  reply	other threads:[~2008-02-25 20:25 UTC|newest]

Thread overview: 68+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-25 12:46 vc-set-mode-line-busy-indicator Nick Roberts
2008-02-25 20:25 ` Nick Roberts [this message]
2008-02-26  4:11   ` vc-set-mode-line-busy-indicator Glenn Morris
2008-02-26  7:38     ` vc-set-mode-line-busy-indicator Nick Roberts
2008-03-01 22:19       ` vc-set-mode-line-busy-indicator Glenn Morris
2008-03-01 22:26         ` vc-set-mode-line-busy-indicator Nick Roberts
2008-03-01 22:53           ` vc-set-mode-line-busy-indicator Glenn Morris
2008-03-02 16:12             ` vc-set-mode-line-busy-indicator Juri Linkov
2008-03-03  1:57               ` vc-set-mode-line-busy-indicator Glenn Morris
2008-03-03 17:13                 ` vc-set-mode-line-busy-indicator Dan Nicolaescu
2008-03-03 21:23                   ` vc-set-mode-line-busy-indicator Nick Roberts
2008-03-03 23:27                     ` vc-set-mode-line-busy-indicator Juri Linkov
2008-03-02 17:25             ` vc-set-mode-line-busy-indicator Richard Stallman
2008-03-02 18:53               ` vc-set-mode-line-busy-indicator Dan Nicolaescu
2008-03-03 18:27                 ` vc-set-mode-line-busy-indicator Richard Stallman
2008-03-03 18:58                   ` vc-set-mode-line-busy-indicator Dan Nicolaescu
2008-03-04 17:38                     ` vc-set-mode-line-busy-indicator Richard Stallman
2008-03-04 18:39                       ` vc-set-mode-line-busy-indicator Dan Nicolaescu
2008-03-05 21:33                         ` vc-set-mode-line-busy-indicator Richard Stallman
2008-03-05 21:50                           ` vc-set-mode-line-busy-indicator Dan Nicolaescu
2008-03-07  3:38                             ` vc-set-mode-line-busy-indicator Richard Stallman
2008-03-07  3:46                               ` vc-set-mode-line-busy-indicator Miles Bader
2008-03-07 17:46                                 ` vc-set-mode-line-busy-indicator Dan Nicolaescu
2008-03-07 18:05                                   ` vc-set-mode-line-busy-indicator Jan Djärv
2008-03-07 18:50                                     ` vc-set-mode-line-busy-indicator Dan Nicolaescu
2008-03-07 22:18                                     ` vc-set-mode-line-busy-indicator Stefan Monnier
2008-03-08  7:03                                       ` vc-set-mode-line-busy-indicator Jan Djärv
2008-03-08 17:39                                 ` vc-set-mode-line-busy-indicator Richard Stallman
2008-03-08 18:57                                   ` Diffs between %s and %s end here (was: vc-set-mode-line-busy-indicator) Reiner Steib
2008-03-08 19:29                                     ` Diffs between %s and %s end here David Kastrup
2008-03-08 19:35                                       ` Dan Nicolaescu
2008-03-08 19:40                                         ` David Kastrup
2008-03-08 21:33                                       ` Juri Linkov
2008-03-08 21:39                                         ` Glenn Morris
2008-03-08 21:59                                           ` Juri Linkov
2008-03-08 23:41                                             ` Glenn Morris
2008-03-08 23:58                                               ` David Kastrup
2008-03-09  0:29                                                 ` Dan Nicolaescu
2008-03-09 10:10                                                   ` David Kastrup
2008-03-09 15:02                                                     ` Dan Nicolaescu
2008-03-09 16:40                                                   ` Richard Stallman
2008-03-09 16:39                                             ` Richard Stallman
2008-03-09 17:57                                               ` Juri Linkov
2008-03-10  6:12                                                 ` Richard Stallman
2008-03-11  0:20                                                   ` David Kastrup
2008-03-09 19:07                                               ` Glenn Morris
2008-03-10  3:02                                                 ` Stefan Monnier
2008-03-10  6:11                                                 ` Richard Stallman
2008-03-10 22:07                                                   ` Glenn Morris
2008-03-11 20:24                                                     ` Richard Stallman
2008-03-09 20:53                                     ` Diffs between %s and %s end here (was: vc-set-mode-line-busy-indicator) Richard Stallman
2008-03-09 22:39                                       ` Diffs between %s and %s end here Reiner Steib
2008-03-08 19:18                                   ` vc-set-mode-line-busy-indicator Dan Nicolaescu
2008-03-09 16:40                                     ` vc-set-mode-line-busy-indicator Richard Stallman
2008-03-09 17:10                                       ` vc-set-mode-line-busy-indicator Dan Nicolaescu
2008-03-09 16:40                                     ` vc-set-mode-line-busy-indicator Richard Stallman
2008-03-07  3:55                               ` vc-set-mode-line-busy-indicator Dan Nicolaescu
2008-03-03  1:56               ` vc-set-mode-line-busy-indicator Glenn Morris
2008-03-03 18:27                 ` vc-set-mode-line-busy-indicator Richard Stallman
2008-03-03 21:04                   ` vc-set-mode-line-busy-indicator Glenn Morris
2008-03-04 17:37                     ` vc-set-mode-line-busy-indicator Richard Stallman
2008-03-03 23:27                   ` vc-set-mode-line-busy-indicator Juri Linkov
2008-03-04 17:38                     ` vc-set-mode-line-busy-indicator Richard Stallman
2008-03-04 19:29                       ` vc-set-mode-line-busy-indicator Juri Linkov
2008-03-04 22:33                         ` vc-set-mode-line-busy-indicator Stefan Monnier
2008-03-05 21:33                         ` vc-set-mode-line-busy-indicator Richard Stallman
2008-03-02  5:53         ` vc-set-mode-line-busy-indicator Stefan Monnier
2008-03-02  6:15           ` vc-set-mode-line-busy-indicator Nick Roberts

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=18371.9275.720477.806834@kahikatea.snap.net.nz \
    --to=nickrob@snap.net.nz \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).