unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Roland Winkler" <Roland.Winkler@physik.uni-erlangen.de>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: rms@gnu.org, emacs-devel@gnu.org
Subject: Re: undoing changes automatically
Date: Wed, 9 Jan 2008 10:10:17 +0100	[thread overview]
Message-ID: <18308.36729.829191.788405@tfkp07.physik.uni-erlangen.de> (raw)
In-Reply-To: <jwvprwbwp3c.fsf-monnier+emacs@gnu.org>

On Wed Jan 9 2008 Stefan Monnier wrote:
> > I looked at the code of cancel-change-group.  It's not clear to me
> > what "Undoing to some unrelated state" means.  I'd expect that
> > atomic-change-group should not produce any errors by itself.
> 
> I guess the message means that cancel-change-group couldn't find the
> path (through undo entries) going from the current state to the
> original state.  More specifically, it means that the current undo-log
> does not contains as one of its nthcdr the head of the original
> undo logs.  That might be the case if the changes to undo are too
> numerous and the undo-log has been truncated to the point where the
> undo-info needed to revert the change are not present any more.

I thought of something like this, though I couldn't phrase it as
nicely and accurately as you did it  :-)

Inside atomic-change-group, bibtex-format-entry does its job for one
BibTeX entry at a time. So typically it operates on 10 to 15 lines
of plain text (~ 300 characters), and it adds about 100 elements to
the undo list. I'd expect that these are still sufficiently small
numbers for atomic-change-group.

I checked in the new code of bibtex.el that uses atomic-change-group.
So we'll see if anybody else runs into similar problems when using
bibtex-mode.

Roland

  reply	other threads:[~2008-01-09  9:10 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-12  1:13 undoing changes automatically Roland Winkler
2007-11-12 10:07 ` Johan Bockgård
2007-11-12 21:23   ` Leo
2007-11-12 20:12 ` David Kastrup
2007-11-12 21:21   ` Roland Winkler
2007-11-13 20:03     ` Richard Stallman
2007-11-13 21:11       ` Stefan Monnier
2007-11-15  5:06       ` Roland Winkler
2008-01-09  1:51       ` Roland Winkler
2008-01-09  5:24         ` Stefan Monnier
2008-01-09  9:10           ` Roland Winkler [this message]
2008-01-09 10:11             ` Roland Winkler
2008-01-09 15:07               ` Stefan Monnier
2008-01-10 12:20                 ` Richard Stallman
2008-01-10 14:43                   ` Stefan Monnier
2008-01-11 13:58                     ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=18308.36729.829191.788405@tfkp07.physik.uni-erlangen.de \
    --to=roland.winkler@physik.uni-erlangen.de \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    --cc=rms@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).