url broken on CVS trunk?

url broken on CVS trunk?

[Nick Roberts]

Tom Tromey's Emacs Lisp Package Archive has the following piece of code that
needs to be evaluated:

    (let ((buffer (url-retrieve-synchronously
  	         "http://tromey.com/elpa/package-install.el")))
    (save-excursion
      (set-buffer buffer)
      (goto-char (point-min))
      (re-search-forward "^$" nil 'move)
      (eval-region (point) (point-max))
      (kill-buffer (current-buffer))))

This works fine on EMACS_22_BASE, but with Emacs on the CVS trunk it gives:


Debugger entered--Lisp error: (wrong-type-argument char-or-string-p cl-struct-url)
  url-scheme-get-property(cl-struct-url loader)
  url-retrieve-internal("http://tromey.com/elpa/package-install.el"...

Is something in url broken?

-- 
Nick                                           http://www.inet.net.nz/~nickrob

Re: url broken on CVS trunk?

[Stefan Monnier]

> Tom Tromey's Emacs Lisp Package Archive has the following piece of code that
> needs to be evaluated:

>     (let ((buffer (url-retrieve-synchronously
>   	         "http://tromey.com/elpa/package-install.el")))
>     (save-excursion
>       (set-buffer buffer)
>       (goto-char (point-min))
>       (re-search-forward "^$" nil 'move)
>       (eval-region (point) (point-max))
>       (kill-buffer (current-buffer))))

> This works fine on EMACS_22_BASE, but with Emacs on the CVS trunk it gives:


> Debugger entered--Lisp error: (wrong-type-argument char-or-string-p cl-struct-url)
>   url-scheme-get-property(cl-struct-url loader)
>   url-retrieve-internal("http://tromey.com/elpa/package-install.el"...

> Is something in url broken?

There's been some changes in url-parse which require recompilation of
its users (i.e. basically all url*.el files).  But that was months ago.
If you haven't bootstrapped in a while, then maybe that's the problem.


        Stefan

Re: url broken on CVS trunk?

[Nick Roberts]

 > > Is something in url broken?
 > 
 > There's been some changes in url-parse which require recompilation of
 > its users (i.e. basically all url*.el files).  But that was months ago.
 > If you haven't bootstrapped in a while, then maybe that's the problem.

Yes, your're right.  I recompiled the lisp files in the url directory and
it works now.  Sorry for the noise.

-- 
Nick                                           http://www.inet.net.nz/~nickrob

Re: url broken on CVS trunk?

[Edward O'Connor]

Nick Roberts <nickrob@snap.net.nz> writes:

> Tom Tromey's Emacs Lisp Package Archive has the following piece of code that
> needs to be evaluated:
>
>     (let ((buffer (url-retrieve-synchronously
>   	         "http://tromey.com/elpa/package-install.el")))
>     (save-excursion
>       (set-buffer buffer)
>       (goto-char (point-min))
>       (re-search-forward "^$" nil 'move)
>       (eval-region (point) (point-max))
>       (kill-buffer (current-buffer))))

Incidentally, it would be better to replace the `re-search-forward' call
with (goto-char url-http-end-of-headers).


-- 
Edward O'Connor
hober0@gmail.com

Ense petit placidam sub libertate quietem.