From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Nick Roberts Newsgroups: gmane.emacs.devel Subject: Re: `term' prefix for gpm support Date: Sat, 22 Sep 2007 13:35:43 +1200 Message-ID: <18164.29039.218922.86203@kahikatea.snap.net.nz> References: <200709211426.l8LEQfuR010254@oogie-boogie.ics.uci.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1190424967 3034 80.91.229.12 (22 Sep 2007 01:36:07 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 22 Sep 2007 01:36:07 +0000 (UTC) Cc: Stefan Monnier , emacs-devel@gnu.org To: Dan Nicolaescu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Sep 22 03:36:05 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IYtud-0004Gm-9P for ged-emacs-devel@m.gmane.org; Sat, 22 Sep 2007 03:36:03 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IYtua-00079H-Te for ged-emacs-devel@m.gmane.org; Fri, 21 Sep 2007 21:36:00 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IYtuY-000791-BJ for emacs-devel@gnu.org; Fri, 21 Sep 2007 21:35:58 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IYtuW-00078p-1V for emacs-devel@gnu.org; Fri, 21 Sep 2007 21:35:57 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IYtuV-00078m-RN for emacs-devel@gnu.org; Fri, 21 Sep 2007 21:35:55 -0400 Original-Received: from viper.snap.net.nz ([202.37.101.8]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IYtuV-0005sj-Aa for emacs-devel@gnu.org; Fri, 21 Sep 2007 21:35:55 -0400 Original-Received: from kahikatea.snap.net.nz (110.63.255.123.dynamic.snap.net.nz [123.255.63.110]) by viper.snap.net.nz (Postfix) with ESMTP id 022BA3DA262; Sat, 22 Sep 2007 13:35:49 +1200 (NZST) Original-Received: by kahikatea.snap.net.nz (Postfix, from userid 1000) id 2B9198FC6D; Sat, 22 Sep 2007 13:35:44 +1200 (NZST) In-Reply-To: <200709211426.l8LEQfuR010254@oogie-boogie.ics.uci.edu> X-Mailer: VM 7.19 under Emacs 23.0.50.10 X-Detected-Kernel: Linux 2.4-2.6 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:79479 Archived-At: > > By the way, am I the only one annoyed by the Gpm code's use of the > > `term' prefix? I mean `term-open-connection' sounds like a very odd > > choice of name for a function which "Open a connection to Gpm." > > Agreed. I would even say that the GPM code in term.c can go into a > separate file, that will reduce the amount of #ifdefs in term.c. Maybe t-mouse-open, t-mouse-close would be better. I can't recall how I arrived at those names but it was probably convoluted. There are four #ifdef HAVE_GPM blocks in term.c which doesn't seem that many (term.c has 21 ifdefs in all). More importantly, when I wrote it, the gpm code called static functions in term.c like write_glyphs. If after multi-tty these functions are no longer part of term.c, maybe the gpm code can go into a separate file. I have no strong opinions about these issues and certainly don't mind if someone wants to make changes. -- Nick http://www.inet.net.nz/~nickrob