unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "T. V. Raman" <raman@users.sf.net>
To: monnier@iro.umontreal.ca
Cc: emacs-pretest-bug@gnu.org, raman@users.sf.net
Subject: Re: 22.1.50; newsticker and buffer-invisibility-spec:
Date: Wed, 22 Aug 2007 03:48:57 -0700	[thread overview]
Message-ID: <18124.5273.269781.53690@gargle.gargle.HOWL> (raw)
In-Reply-To: <jwv4piuuw4d.fsf-monnier+emacs@gnu.org>

Its bizarre use of buffer-invisibility-spec was triggering a bug
in the context of Emacspeak. I've fixed my code to work around it
-- but it would be good to get newsticker fixed up to match
emacs' use of buffer-invisibility-spec.



>>>>> "Stefan" == Stefan Monnier <monnier@iro.umontreal.ca> writes:
    >> I've not used newsticker in a while, and I noticed today
    >> that there seems to be a problem with the way
    >> buffer-invisibility-spec is getting handled in newsticker
    >> buffers.
    Stefan> 
    >> Could someone who can see the display look at it and
    >> confirm that there is a problem, or that it is indeed
    >> doing the right thing so I can chase this down further?
    Stefan> 
    Stefan> I don't know how to run the newsticker code to try it
    Stefan> out, but the code looks odd indeed: it presumes that
    Stefan> the invisibility property can be a list of values and
    Stefan> that if one of those values is a member of
    Stefan> buffer-invisibility-spec then the text is invisible.
    Stefan> But in reality, the invisible property is not treated
    Stefan> as a list, its value (which could presumably be a
    Stefan> list, but that would be asking for trouble) is
    Stefan> directly looked up in buffer-invisibility-spec.
    Stefan> I.e. newsticker--lists-intersect-p (which is always
    Stefan> called with (get-text-property FOO 'invisible) as
    Stefan> first arg and buffer-invisibility-spec as second, so
    Stefan> it should really be replaced by a new function
    Stefan> newsticker--invisible-p) should be
    Stefan> newsticker--list-member-p or somesuch.
    Stefan> 
    Stefan> But fixing this function is not enough because the
    Stefan> rest of the code makes use of the nonexistent
    Stefan> feature.  I've looked at the XEmacs-21.4.20 docstring
    Stefan> for buffer-invisibility-spec and it doesn't seem to
    Stefan> document such an extension either, so I have no idea
    Stefan> in which circumstance this code may work.
    Stefan> 
    Stefan> The problematic code was part of the 1.1 revision
    Stefan> (checked in on 12 Sep 2005), so there's no change log
    Stefan> to explain the problem.
    Stefan> 
    Stefan> 
    Stefan>         Stefan
    Stefan> 
    Stefan> 
    Stefan> _______________________________________________
    Stefan> Emacs-devel mailing list Emacs-devel@gnu.org
    Stefan> http://lists.gnu.org/mailman/listinfo/emacs-devel

-- 
Best Regards,
--raman

      
Email:  raman@users.sf.net
WWW:    http://emacspeak.sf.net/raman/
AIM:    emacspeak       GTalk: tv.raman.tv@gmail.com
PGP:    http://emacspeak.sf.net/raman/raman-almaden.asc
Google: tv+raman 
IRC:    irc://irc.freenode.net/#emacs

  reply	other threads:[~2007-08-22 10:48 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-20 13:28 22.1.50; newsticker and buffer-invisibility-spec: raman
2007-08-20 14:20 ` Tassilo Horn
2007-08-22 10:47   ` T. V. Raman
2007-08-20 14:27 ` Stefan Monnier
2007-08-22 10:48   ` T. V. Raman [this message]
2007-08-22 18:55     ` Ulf Jasper
2007-08-25 15:32       ` Ulf Jasper
2007-08-25 19:49         ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=18124.5273.269781.53690@gargle.gargle.HOWL \
    --to=raman@users.sf.net \
    --cc=emacs-pretest-bug@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).