From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: =?ISO-8859-1?Q?R=FCdiger?= Sonderfeld Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] eww improvements Date: Sun, 23 Jun 2013 23:48:21 +0200 Message-ID: <1807166.Zehk92YRjO@descartes> References: <8738s8ix1k.fsf@kanis.fr> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1372024118 11225 80.91.229.3 (23 Jun 2013 21:48:38 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 23 Jun 2013 21:48:38 +0000 (UTC) Cc: Ivan Kanis , Lars Magne Ingebrigtsen , Lars Grunewaldt To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jun 23 23:48:39 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Uqs9H-0004ek-1E for ged-emacs-devel@m.gmane.org; Sun, 23 Jun 2013 23:48:39 +0200 Original-Received: from localhost ([::1]:55126 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uqs9G-00039I-KT for ged-emacs-devel@m.gmane.org; Sun, 23 Jun 2013 17:48:38 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38736) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uqs9C-000399-KM for emacs-devel@gnu.org; Sun, 23 Jun 2013 17:48:37 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uqs99-0008Aj-MZ for emacs-devel@gnu.org; Sun, 23 Jun 2013 17:48:34 -0400 Original-Received: from ptmx.org ([178.63.28.110]:45110) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uqs99-0008AO-GU for emacs-devel@gnu.org; Sun, 23 Jun 2013 17:48:31 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by ptmx.org (Postfix) with ESMTP id 0CBE221C5F; Sun, 23 Jun 2013 23:48:29 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at ptmx.org Original-Received: from ptmx.org ([127.0.0.1]) by localhost (ptmx.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rdJHyfRcWg59; Sun, 23 Jun 2013 23:48:27 +0200 (CEST) Original-Received: from descartes.localnet (chello080108246092.7.14.vie.surfer.at [80.108.246.92]) by ptmx.org (Postfix) with ESMTPSA id 680D71FEA5; Sun, 23 Jun 2013 23:48:26 +0200 (CEST) User-Agent: KMail/4.10.3 (Linux/3.8.0-23-generic; KDE/4.10.3; x86_64; ; ) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 178.63.28.110 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:160919 Archived-At: On Sunday 23 June 2013 20:29:55 Lars Magne Ingebrigtsen wrote: > Ivan Kanis writes: > > I have attached 3 patches for eww. >=20 > Thanks; all applied. http://bzr.savannah.gnu.org/lh/emacs/trunk/revision/113144 I don't think + (cond ((eq system-type 'windows-nt) + 'browse-url-default-windows-browser) + ((eq system-type 'darwin) + 'browse-url-default-macosx-browser) + (t + 'browse-url-netscape)) is a good choice for `eww-external-browser'. Who still uses netscape? = And why=20 duplicate all the effort to find the default browser when this is alrea= dy done=20 in browse-url.el? I think using `browse-url-default-browser' as default value makes more = sense. We could also try to use `browse-url-browser-function', unless it is se= t to=20 eww itself: (if (memq browse-url-browser-function '(eww-browse-url eww)) #'browse-url-default-browser browse-url-browser-function) Regards, R=C3=BCdiger