unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Rüdiger Sonderfeld" <ruediger@c-plusplus.de>
To: emacs-devel@gnu.org
Cc: Ivan Kanis <ivan@kanis.fr>,
	Lars Magne Ingebrigtsen <larsi@gnus.org>,
	Lars Grunewaldt <lars.grunewaldt@osnanet.de>
Subject: Re: [PATCH] eww improvements
Date: Sun, 23 Jun 2013 23:48:21 +0200	[thread overview]
Message-ID: <1807166.Zehk92YRjO@descartes> (raw)
In-Reply-To: <m361x43ckc.fsf@stories.gnus.org>

On Sunday 23 June 2013 20:29:55 Lars Magne Ingebrigtsen wrote:
> Ivan Kanis <ivan@kanis.fr> writes:
> > I have attached 3 patches for eww.
> 
> Thanks; all applied.

http://bzr.savannah.gnu.org/lh/emacs/trunk/revision/113144

I don't think

+  (cond ((eq system-type 'windows-nt)
+        'browse-url-default-windows-browser)
+       ((eq system-type 'darwin)
+        'browse-url-default-macosx-browser)
+       (t
+        'browse-url-netscape))

is a good choice for `eww-external-browser'.  Who still uses netscape? And why 
duplicate all the effort to find the default browser when this is already done 
in browse-url.el?

I think using `browse-url-default-browser' as default value makes more sense.

We could also try to use `browse-url-browser-function', unless it is set to 
eww itself:

  (if (memq browse-url-browser-function '(eww-browse-url eww))
        #'browse-url-default-browser
      browse-url-browser-function)

Regards,
Rüdiger




  reply	other threads:[~2013-06-23 21:48 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-23 16:58 [PATCH] eww improvements Ivan Kanis
2013-06-23 18:29 ` Lars Magne Ingebrigtsen
2013-06-23 21:48   ` Rüdiger Sonderfeld [this message]
2013-06-23 21:52     ` Lars Magne Ingebrigtsen
     [not found]       ` <13724493.P5Ma8CTG7m@descartes>
2013-06-24 13:58         ` Lars Magne Ingebrigtsen
2013-06-24  5:24     ` Ivan Kanis
2013-06-24 11:14       ` Rüdiger Sonderfeld
2013-06-24 13:03         ` Ivan Kanis
2013-06-24 13:18           ` Rüdiger Sonderfeld
2013-06-24 17:01             ` Ivan Kanis
2013-06-24 17:40               ` Lars Magne Ingebrigtsen
2013-06-25  6:07 ` Juri Linkov
2013-06-25  6:29   ` Ivan Kanis
2013-06-25 19:26   ` Lars Magne Ingebrigtsen
2013-06-25 20:15     ` Ivan Kanis
2013-06-25 20:20       ` Lars Magne Ingebrigtsen
2013-06-25 20:22       ` Ivan Kanis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1807166.Zehk92YRjO@descartes \
    --to=ruediger@c-plusplus.de \
    --cc=emacs-devel@gnu.org \
    --cc=ivan@kanis.fr \
    --cc=lars.grunewaldt@osnanet.de \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).