From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Nick Roberts Newsgroups: gmane.emacs.devel Subject: Re: Bug in change in button.el? Date: Wed, 25 Apr 2007 11:20:20 +1200 Message-ID: <17966.37044.847300.217748@farnswood.snap.net.nz> References: <6rslaq65sp.fsf@fencepost.gnu.org> <17966.33559.852546.313154@farnswood.snap.net.nz> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1177456953 11613 80.91.229.12 (24 Apr 2007 23:22:33 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 24 Apr 2007 23:22:33 +0000 (UTC) Cc: rms@gnu.org, emacs-devel@gnu.org To: Glenn Morris Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Apr 25 01:22:31 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1HgUL8-0006LE-LW for ged-emacs-devel@m.gmane.org; Wed, 25 Apr 2007 01:22:30 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HgUQh-0000bH-40 for ged-emacs-devel@m.gmane.org; Tue, 24 Apr 2007 19:28:15 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HgUQd-0000b2-PY for emacs-devel@gnu.org; Tue, 24 Apr 2007 19:28:11 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HgUQc-0000aq-Cb for emacs-devel@gnu.org; Tue, 24 Apr 2007 19:28:11 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HgUQc-0000an-6r for emacs-devel@gnu.org; Tue, 24 Apr 2007 19:28:10 -0400 Original-Received: from viper.snap.net.nz ([202.37.101.8]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1HgUL1-0001tv-7u; Tue, 24 Apr 2007 19:22:23 -0400 Original-Received: from farnswood.snap.net.nz (187.61.255.123.dynamic.snap.net.nz [123.255.61.187]) by viper.snap.net.nz (Postfix) with ESMTP id CE2BB3DB116; Wed, 25 Apr 2007 11:22:21 +1200 (NZST) Original-Received: by farnswood.snap.net.nz (Postfix, from userid 500) id 74A9B627ED; Wed, 25 Apr 2007 00:20:21 +0100 (BST) In-Reply-To: X-Mailer: VM 7.19 under Emacs 22.0.98.2 X-detected-kernel: Linux 2.4-2.6 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:70019 Archived-At: > > But this seems a bit tortuous. If we want to do this, button might > > as well just inherit from the underline face. > > Why is is tortuous to say "use underline if supported, else try colour"? So Emacs is consistent in what it does when underlining is not supported. > If it inherits from underline, it will use either underline or bold, > so that's different yet again. Previously it did nothing (apart from on MS-DOS), bold (if available) would be fine. However I don't quite understand the specification because it seems to default to :underline when neither underline or bold are supported. (defface underline '((((supports :underline t)) :underline t) (((supports :weight bold)) :weight bold) (t :underline t)) "Basic underlined face." :group 'basic-faces) > My suggestion would (I think) get the behaviour you initially wanted; > ie colour when underlining does not work. And a colour already > extensively used on MS-DOS, so it must be OK. > > Otherwise let's just go back to how it was originally, with > indistinguishable buttons on the linux console. No let's sort this case, and leave behaviour otherwise unchanged. RMS can decide which solution to use. -- Nick http://www.inet.net.nz/~nickrob