From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Nick Roberts Newsgroups: gmane.emacs.devel Subject: Re: Bug in change in button.el? Date: Wed, 25 Apr 2007 10:22:15 +1200 Message-ID: <17966.33559.852546.313154@farnswood.snap.net.nz> References: <6rslaq65sp.fsf@fencepost.gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1177453471 25954 80.91.229.12 (24 Apr 2007 22:24:31 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 24 Apr 2007 22:24:31 +0000 (UTC) Cc: rms@gnu.org, emacs-devel@gnu.org To: Glenn Morris Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Apr 25 00:24:29 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1HgTQy-0000mT-SK for ged-emacs-devel@m.gmane.org; Wed, 25 Apr 2007 00:24:29 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HgTWX-0001dO-2m for ged-emacs-devel@m.gmane.org; Tue, 24 Apr 2007 18:30:13 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HgTWU-0001cR-3C for emacs-devel@gnu.org; Tue, 24 Apr 2007 18:30:10 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HgTWS-0001aj-CM for emacs-devel@gnu.org; Tue, 24 Apr 2007 18:30:09 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HgTWS-0001ac-94 for emacs-devel@gnu.org; Tue, 24 Apr 2007 18:30:08 -0400 Original-Received: from viper.snap.net.nz ([202.37.101.8]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1HgTQr-0002Wt-F6; Tue, 24 Apr 2007 18:24:21 -0400 Original-Received: from farnswood.snap.net.nz (187.61.255.123.dynamic.snap.net.nz [123.255.61.187]) by viper.snap.net.nz (Postfix) with ESMTP id D97AF3DAFF4; Wed, 25 Apr 2007 10:24:18 +1200 (NZST) Original-Received: by farnswood.snap.net.nz (Postfix, from userid 500) id 7B6FC627ED; Tue, 24 Apr 2007 23:22:17 +0100 (BST) In-Reply-To: X-Mailer: VM 7.19 under Emacs 22.0.98.2 X-detected-kernel: Linux 2.4-2.6 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:70005 Archived-At: > > Do you mean the change to inherit from `link'? > > I thought we did not want buttons to look just like links. > > Also, what the definition of `link' does is use color and underlining > > together, although each one of them works only when supported. > > Then I guess this change is better. The (type pc) test can be removed > if MS-DOS correctly answers the (supports) question. But this seems a bit tortuous. If we want to do this, button might as well just inherit from the underline face. > *** button.el 23 Apr 2007 03:32:12 -0000 1.27 > --- button.el 24 Apr 2007 22:00:18 -0000 > *************** > *** 52,62 **** > ;; Globals > > ;; Use color for the MS-DOS port because it doesn't support underline. > - ;; Also for the linux console. > (defface button '((((type pc) (class color)) > (:foreground "lightblue")) > ! (((type tty)) (:inherit link)) > ! (t :underline t)) > "Default face used for buttons." > :group 'basic-faces) > > --- 52,61 ---- > ;; Globals > > ;; Use color for the MS-DOS port because it doesn't support underline. > (defface button '((((type pc) (class color)) > (:foreground "lightblue")) > ! (((supports :underline t)) :underline t) > ! (t (:foreground "lightblue"))) > "Default face used for buttons." > :group 'basic-faces) > > > > > _______________________________________________ > Emacs-devel mailing list > Emacs-devel@gnu.org > http://lists.gnu.org/mailman/listinfo/emacs-devel -- Nick http://www.inet.net.nz/~nickrob