menu-bar-map variable

menu-bar-map variable

[Nick Roberts]

An earlier thread suggested that tool bar icons should _add to_ rather than
replace existing icons.  I would like to suggest the converse for the menubar
i.e. a variable, menu-bar-map, that can be made buffer-local like tool-bar-map
can.  The reason for this is that I'd like to use the menu-bar like a tool bar
on text-only terminals, but currently the global menu items get in the way.  A
buffer-local variable would allow them to be hidden.

Actually, I don't understand why the tool-bar has it's own map, while the
menu-bar doesn't anyway.


-- 
Nick                                           http://www.inet.net.nz/~nickrob

Re: menu-bar-map variable

[Richard Stallman]

    An earlier thread suggested that tool bar icons should _add to_ rather than
    replace existing icons.  I would like to suggest the converse for the menubar
    i.e. a variable, menu-bar-map, that can be made buffer-local like tool-bar-map
    can.  The reason for this is that I'd like to use the menu-bar like a tool bar
    on text-only terminals, but currently the global menu items get in the way.

There is a feature by which a minor mode can turn off specific global
menu items.  It should be in the manual.

    Actually, I don't understand why the tool-bar has it's own map, while the
    menu-bar doesn't anyway.

On general principles, I think the tool bar should be handled just
like the menu bar, with a phony prefix key that can be used in any
active map.

Is there any practical reason not to change that, after the release?

Re: menu-bar-map variable

[Nick Roberts]

 > There is a feature by which a minor mode can turn off specific global
 > menu items.  It should be in the manual.

Unfortunately tmm-menubar-mouse doesn't seem to work with this feature
(items that are no longer visible get selected).

 >     Actually, I don't understand why the tool-bar has it's own map, while the
 >     menu-bar doesn't anyway.
 > 
 > On general principles, I think the tool bar should be handled just
 > like the menu bar, with a phony prefix key that can be used in any
 > active map.
 >
 > Is there any practical reason not to change that, after the release?

I presume not.  I'll wait for this change.


-- 
Nick                                           http://www.inet.net.nz/~nickrob

Re: menu-bar-map variable

[Richard Stallman]

     > There is a feature by which a minor mode can turn off specific global
     > menu items.  It should be in the manual.

    Unfortunately tmm-menubar-mouse doesn't seem to work with this feature
    (items that are no longer visible get selected).

Can someone fix this?

Re: menu-bar-map variable

[Nick Roberts]

Richard Stallman writes:
 >      > There is a feature by which a minor mode can turn off specific global
 >      > menu items.  It should be in the manual.
 > 
 >     Unfortunately tmm-menubar-mouse doesn't seem to work with this feature
 >     (items that are no longer visible get selected).
 > 
 > Can someone fix this?

I can localise the problem to tmm-get-keybind and these two lines:

 (setq allbind (cons (local-key-binding keyseq) allbind))
 (setq allbind (cons (global-key-binding keyseq) allbind))

If I remove a menu-item in the global map e.g file

(define-key global-map [menu-bar file] 'undefined)

the tmm handles this properly as the entry is removed from
(global-key-binding [menu-bar]):

(keymap (file . undefined)...

However, if I remove a menu-item in the local map, e.g, edit in the scratch
buffer:

(define-key lisp-interaction-mode-map [menu-bar edit] 'undefined)

then I get:

(local-key-binding [menu-bar])
(keymap (edit . undefined))

but tmm still thinks it's there because it's still in the global list

(global-key-binding [menu-bar]):

...(edit "Edit" keymap (undo ...
          ^^^^

Perhaps Emacs has it's own function to handle this.

There is no corresponding problem with a graphical display.

-- 
Nick                                           http://www.inet.net.nz/~nickrob

Re: menu-bar-map variable

[Richard Stallman]

    (define-key lisp-interaction-mode-map [menu-bar edit] 'undefined)

    then I get:

    (local-key-binding [menu-bar])
    (keymap (edit . undefined))

    but tmm still thinks it's there because it's still in the global list

    (global-key-binding [menu-bar]):

    ...(edit "Edit" keymap (undo ...
	      ^^^^

Well, that shows the bug.  The definition as `undefined'
in the local map should not just be discarded.  It should be kept,
so that it overrides the global binding.  Only at the last moment
should it be treated as no definition.

Re: menu-bar-map variable

[Nick Roberts]

 >     (define-key lisp-interaction-mode-map [menu-bar edit] 'undefined)
 > 
 >     then I get:
 > 
 >     (local-key-binding [menu-bar])
 >     (keymap (edit . undefined))
 > 
 >     but tmm still thinks it's there because it's still in the global list
 > 
 >     (global-key-binding [menu-bar]):
 > 
 >     ...(edit "Edit" keymap (undo ...
 > 	      ^^^^
 > 
 > Well, that shows the bug.  The definition as `undefined'
 > in the local map should not just be discarded.  It should be kept,
 > so that it overrides the global binding.  Only at the last moment
 > should it be treated as no definition.

I've fixed this now.

-- 
Nick                                           http://www.inet.net.nz/~nickrob

Re: menu-bar-map variable

[Richard Stallman]

Thanks.