From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] (icomplete-vertical-mode): Add support for affixations and, annotations Date: Wed, 2 Jun 2021 17:11:32 +0300 Message-ID: <1792c288-18ef-410f-479f-6dec5da16aef@yandex.ru> References: <43d1599e-2ba9-2efb-45c3-76c67d29a69d@daniel-mendler.de> <87tumrgqrb.fsf@gmail.com> <87tumq92pe.fsf@mail.linkov.net> <87lf82g10g.fsf@gmail.com> <87y2c24lww.fsf@mail.linkov.net> <871r9t2lsy.fsf@mail.linkov.net> <22880197-6d05-c821-2c58-328ed3cfc02e@daniel-mendler.de> <87eedruui3.fsf@gmail.com> <8dd915fe-fe67-2a45-67ff-8aaa3e9b9aca@daniel-mendler.de> <878s3zuq47.fsf@gmail.com> <09f2a253-84ba-5cfd-552e-0b89109864a5@daniel-mendler.de> <875yyxaoxp.fsf@gmail.com> <871r9laj6a.fsf@gmail.com> <1a183c3b.2f2f.179cb27f64c.Coremail.tumashu@163.com> <87lf7s7lli.fsf@gmail.com> <2dd59f1c-1d4d-a7d7-fae5-d9ca9b5c90c2@yandex.ru> <8e0cfb49-4ce3-c9aa-21fd-f0063b7c8107@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33894"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 Cc: tumashu , Juri Linkov , "emacs-devel@gnu.org" , Daniel Mendler To: Stefan Monnier , =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Jun 02 16:12:26 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1loRbe-0008Xn-7j for ged-emacs-devel@m.gmane-mx.org; Wed, 02 Jun 2021 16:12:26 +0200 Original-Received: from localhost ([::1]:49004 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1loRbd-0003IH-7X for ged-emacs-devel@m.gmane-mx.org; Wed, 02 Jun 2021 10:12:25 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50940) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1loRat-0002af-8G for emacs-devel@gnu.org; Wed, 02 Jun 2021 10:11:39 -0400 Original-Received: from mail-wr1-x42d.google.com ([2a00:1450:4864:20::42d]:38526) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1loRaq-0006pi-OE for emacs-devel@gnu.org; Wed, 02 Jun 2021 10:11:38 -0400 Original-Received: by mail-wr1-x42d.google.com with SMTP id j14so2475001wrq.5 for ; Wed, 02 Jun 2021 07:11:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ruFBnKbclHFUEu4dY6QOZIQiHZJdGwmdGixPbLc1wVE=; b=lZ6yXPTnqM4hRhOoeuICo1/Aq4le2zt4MyXyHB7vT99YKqId0qgLLx9P64uR61yyF/ QwNp+bHHZK8wDrz7VsduUsEkXlWa1TkMOYlnQ4a5viKZzwcN17O+6eZr54IeYWA0jJr2 IaKxO1TfUrv6ldkrOWqu3EAvu3EzPA8FznkDeQMU2Fv6d9OmLMUoZERI3tCxarDJyD2i nQVPuF0dCncPp/NLkDMPAbmKkGPZUGvWlC9pN90O8ni3WltCe8DSeBuPAB9biL9wIDWX Bp75mp8ySzZAA2N/5XmRbNbqEFDa5lxH/JQv1vrYUVxbAfrrSWj6hzf6Cdj3CLYijT2q vKcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ruFBnKbclHFUEu4dY6QOZIQiHZJdGwmdGixPbLc1wVE=; b=nNheFzyq5c4IlGp3KwXrz4PxocgaGKRLxVtCsq9yOnP5MeSBx2ID+X2VsE4Qr9InZ3 IKqqW2IR4OU580C25z7520Jn9q2AHGcK7o7RhAcXYKVj9LZifg7c+ZDLKYjp4GygiYWl kzFlDsC6WtEZzVEPf1NyWZcOCjV8BnrGBzT21znSpMhxo/AnaCqsHz188d7BiDvyWHGy GUs+ShjFyf9H2woQT4RdJU7hecgkrOn7Q+vpx8tVoYNrwgIUTih1si3HvaVIJ7uEq3qO 5ljB7V3gwc471ZYWrBtpwASOU4B9JdrQ26Vp9/eUEqudxqh0Vj7Xki+9R+dy988DYAAj UY0Q== X-Gm-Message-State: AOAM531T+fsIJCrXIVdM1zDl3+9J4bpoge/SoiZmhCThIebPvK4N/Ac1 gVwqXKvzBh00t8IU10v4Fdhj72BpJgc= X-Google-Smtp-Source: ABdhPJxwbjap9wh4586o7xe2e6zVsgNeQ0wGjsNzklQ/jfl9WJYAbCet2J6QnFqS/2EYWL1QPN1AZQ== X-Received: by 2002:a5d:548b:: with SMTP id h11mr22032011wrv.131.1622643094912; Wed, 02 Jun 2021 07:11:34 -0700 (PDT) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id n10sm85657wre.95.2021.06.02.07.11.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Jun 2021 07:11:34 -0700 (PDT) In-Reply-To: Content-Language: en-US Received-SPF: pass client-ip=2a00:1450:4864:20::42d; envelope-from=raaahh@gmail.com; helo=mail-wr1-x42d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.248, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NICE_REPLY_A=-0.613, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:270292 Archived-At: On 02.06.2021 16:38, Stefan Monnier wrote: > I think it was/is the fear that the overlay could interfere with > the command. Same as the reason for Company's frontends doing that, then (only more founded in that case). If somebody reports a real problem caused by this, we can copy the corresponding fix more thoroughly: - Remove the after-string from the overlay (moving its value to some other property) in pre-command. - Restore it right away in post-command. And then update after the computation is made. But we probably don't need this additional complexity. > AFAIK it was written under the assumption that the > `icomplete-tidy` call would be automatically "undone" by the > `post-command-hook` before the next redisplay. Are you okay with the proposed change, then? And how do you feel about reducing icomplete-compute-delay to 100ms at most?