unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Nick Roberts <nickrob@snap.net.nz>
To: storm@cua.dk (Kim F. Storm)
Cc: Chong Yidong <cyd@stupidchicken.com>,
	emacs-devel@gnu.org, rms@gnu.org, bojohan+news@dd.chalmers.se
Subject: Re: mouse-1-click-follows-link with t-mouse
Date: Mon, 19 Mar 2007 23:17:12 +1200	[thread overview]
Message-ID: <17918.28984.190415.507648@kahikatea.snap.net.nz> (raw)
In-Reply-To: <m3y7ltwl2i.fsf@kfs-l.imdomain.dk>

 > > When is this condition needed?  I couldn't get it to fail on a graphical
 > > display.
 > 
 > I don't recall why I made the check for input-pending-p, but
 > it looks like it is meant to catch a double click on a link - 
 > i.e. so that a double-click does not follow the link.
 > 
 > But that doesn't really work - and it also seems that the test could
 > potentially make the whole feature unstable, as other unrelated input
 > events could accidentally prevent the mouse click from following the link.
 > 
 > So I think we can just remove the test.

That would be good.  The client program mev, used by t-mouse, outputs time
information which isn't currently used in t-mouse.el.  The patch below allows
Emacs to follow the delay specified by mouse-1-click-follows-link in a
console.

-- 
Nick                                           http://www.inet.net.nz/~nickrob



*** t-mouse.el	20 Jan 2007 20:58:47 +1300	1.7
--- t-mouse.el	19 Mar 2007 23:08:57 +1200	
*************** For example, \"2\" for /dev/tty2."
*** 134,147 ****
  
  (defun t-mouse-make-event-element (x-dot-y-avec-time)
    (let* ((x-dot-y (nth 0 x-dot-y-avec-time))
           (x (car x-dot-y))
           (y (cdr x-dot-y))
           (w (window-at x y))
           (ltrb (window-edges w))
           (left (nth 0 ltrb))
!          (top (nth 1 ltrb)))
!     (if w (posn-at-x-y (- x left) (- y top) w t)
!       (append (list nil 'menu-bar) (nthcdr 2 (posn-at-x-y x y w t))))))
  
  ;;; This fun is partly Copyright (C) 1994 Per Abrahamsen <abraham@iesd.auc.dk>
  (defun t-mouse-make-event ()
--- 134,152 ----
  
  (defun t-mouse-make-event-element (x-dot-y-avec-time)
    (let* ((x-dot-y (nth 0 x-dot-y-avec-time))
+ 	 (time (nth 1 x-dot-y-avec-time))
           (x (car x-dot-y))
           (y (cdr x-dot-y))
           (w (window-at x y))
           (ltrb (window-edges w))
           (left (nth 0 ltrb))
!          (top (nth 1 ltrb))
! 	 (event (if w
! 		    (posn-at-x-y (- x left) (- y top) w t)
! 		  (append (list nil 'menu-bar)
! 			  (nthcdr 2 (posn-at-x-y x y w t))))))
!     (setcar (nthcdr 3 event) time)
!     event))
  
  ;;; This fun is partly Copyright (C) 1994 Per Abrahamsen <abraham@iesd.auc.dk>
  (defun t-mouse-make-event ()

  reply	other threads:[~2007-03-19 11:17 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-03 23:56 Updating the homepage Yavor Doganov
2007-03-04  4:15 ` Eli Zaretskii
2007-03-04 13:01   ` Yavor Doganov
2007-03-04 13:13     ` Romain Francoise
2007-03-05  2:55       ` Richard Stallman
2007-03-05  4:12         ` Stefan Monnier
2007-03-05  7:20           ` David Kastrup
2007-03-05 21:49           ` Richard Stallman
2007-03-05 22:04       ` JD Smith
2007-03-06  9:44         ` Romain Francoise
2007-03-06 10:00           ` martin rudalics
2007-03-06 19:48             ` Romain Francoise
2007-03-06 10:18           ` David Hansen
2007-03-06 23:35           ` Daniel Brockman
2007-03-06 23:46             ` Nick Roberts
2007-03-25 13:32               ` Romain Francoise
2007-03-09 21:34             ` Dieter Wilhelm
2007-03-25 13:32               ` Romain Francoise
2007-03-16 14:06             ` mouse-1-click-follows-link with t-mouse (was: Updating the homepage) Johan Bockgård
2007-03-18 12:19               ` Richard Stallman
2007-03-18 14:37                 ` mouse-1-click-follows-link with t-mouse Chong Yidong
2007-03-18 23:21                   ` Johan Bockgård
2007-03-19  2:22                     ` Nick Roberts
2007-03-19 18:10                     ` Richard Stallman
2007-03-19  5:14                   ` Richard Stallman
2007-03-19 10:33                     ` Nick Roberts
2007-03-19 11:04                       ` Kim F. Storm
2007-03-19 11:17                         ` Nick Roberts [this message]
2007-03-19 12:09                           ` Kim F. Storm
2007-03-19 15:56                           ` Chong Yidong
2007-03-19 21:57                           ` Richard Stallman
2007-03-19 22:46                             ` Nick Roberts
2007-03-21  0:41                               ` Richard Stallman
2007-03-21  9:20                                 ` Kim F. Storm
2007-03-21  0:49                               ` mouse-1-click-follows-link with xt-mouse (was: with t-mouse) Nick Roberts
2007-03-21 10:07                                 ` Kim F. Storm
2007-03-21 20:45                                   ` Nick Roberts
2007-03-21 18:16                                 ` Richard Stallman
2007-03-19 15:57                         ` mouse-1-click-follows-link with t-mouse Chong Yidong
2007-03-25 13:31             ` Updating the homepage Romain Francoise
2007-03-25 14:21               ` Drew Adams
2007-03-25 22:41                 ` David Kastrup
2007-04-09 20:20                 ` Romain Francoise
2007-03-25 20:23               ` Eli Zaretskii
2007-03-25 22:42                 ` David Kastrup
2007-03-26  1:53                   ` YAMAMOTO Mitsuharu
2007-04-09 20:21                 ` Romain Francoise
2007-03-06  5:40     ` Yavor Doganov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=17918.28984.190415.507648@kahikatea.snap.net.nz \
    --to=nickrob@snap.net.nz \
    --cc=bojohan+news@dd.chalmers.se \
    --cc=cyd@stupidchicken.com \
    --cc=emacs-devel@gnu.org \
    --cc=rms@gnu.org \
    --cc=storm@cua.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).