From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Nick Roberts Newsgroups: gmane.emacs.devel Subject: Re: [lennart.borgman.073@student.lu.se: compilation-previous-error fails if first error is at start of buffer] Date: Thu, 11 Jan 2007 17:05:41 +1300 Message-ID: <17829.46997.252640.261182@kahikatea.snap.net.nz> References: <45A1F9F1.4050500@swipnet.se> <17826.570.959259.398020@kahikatea.snap.net.nz> <45A226FF.30507@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1168488384 4038 80.91.229.12 (11 Jan 2007 04:06:24 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 11 Jan 2007 04:06:24 +0000 (UTC) Cc: =?ISO-8859-1?Q?Jan_Dj=E4rv?= , rms@gnu.org, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jan 11 05:06:22 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1H4rCf-0003ZJ-Pq for ged-emacs-devel@m.gmane.org; Thu, 11 Jan 2007 05:06:14 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1H4rCf-0005gv-Ku for ged-emacs-devel@m.gmane.org; Wed, 10 Jan 2007 23:06:13 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1H4rCT-0005eY-53 for emacs-devel@gnu.org; Wed, 10 Jan 2007 23:06:01 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1H4rCR-0005cU-26 for emacs-devel@gnu.org; Wed, 10 Jan 2007 23:06:00 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1H4rCQ-0005cR-TX for emacs-devel@gnu.org; Wed, 10 Jan 2007 23:05:58 -0500 Original-Received: from [202.37.101.8] (helo=viper.snap.net.nz) by monty-python.gnu.org with esmtp (Exim 4.52) id 1H4rCN-0001BK-2K; Wed, 10 Jan 2007 23:05:55 -0500 Original-Received: from kahikatea.snap.net.nz (p202-124-125-216.snap.net.nz [202.124.125.216]) by viper.snap.net.nz (Postfix) with ESMTP id 598E33D83A3; Thu, 11 Jan 2007 17:05:49 +1300 (NZDT) Original-Received: by kahikatea.snap.net.nz (Postfix, from userid 500) id BF5884F702; Thu, 11 Jan 2007 17:05:46 +1300 (NZDT) Original-To: "Lennart Borgman (gmail)" In-Reply-To: <45A226FF.30507@gmail.com> X-Mailer: VM 7.19 under Emacs 22.0.92.8 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:65144 Archived-At: >... > (You may have to edit this a bit because of line breaks in this mail > message.) Now do > > M-x compilation-mode > > Go to the beginning of the buffer. Press TAB. The point should move to > the second error line. Press TAB again -> to third line. > > Now press S-TAB. Should go to second line. S-TAB again should go to > first line, but it does not. > > Is this enough to reproduce it for you? Does this fix it? You'll need to gorilla test it to check there are no new bugs. -- Nick http://www.inet.net.nz/~nickrob *** compile.el 09 Jan 2007 17:31:50 +1300 1.414 --- compile.el 11 Jan 2007 17:03:44 +1300 *************** Just inserts the text, but uses `insert- *** 1500,1508 **** (error ,error compilation-error)) ;; prop 'message usually has 2 changes, on and off, so re-search if off (or (setq msg (get-text-property pt 'message)) ! (if (setq pt (,property-change pt 'message)) ! (setq msg (get-text-property pt 'message))) ! (error ,error compilation-error)) (or (< (cadr msg) compilation-skip-threshold) (if different-file (eq (prog1 last (setq last (nth 2 (car msg)))) --- 1500,1510 ---- (error ,error compilation-error)) ;; prop 'message usually has 2 changes, on and off, so re-search if off (or (setq msg (get-text-property pt 'message)) ! (progn ! (setq pt (or (,property-change pt 'message) ! (if (> n 0) (point-max) (point-min)))) ! (unless (setq msg (get-text-property pt 'message)) ! (error ,error compilation-error)))) (or (< (cadr msg) compilation-skip-threshold) (if different-file (eq (prog1 last (setq last (nth 2 (car msg)))) *************** Does NOT find the source line like \\[ne *** 1543,1551 **** (if (get-buffer-process (current-buffer)) "No more %ss yet" "Moved past last %s")) - ;; Don't move "back" to message at or before point. - ;; Pass an explicit (point-min) to make sure pt is non-nil. - (setq pt (previous-single-property-change pt 'message nil (point-min))) (compilation-loop < previous-single-property-change 1+ "Moved back before first %s"))) (goto-char pt) --- 1545,1550 ----