From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: rsharman@pobox.com Newsgroups: gmane.emacs.devel Subject: Re: highlight-changes-mode Date: Wed, 6 Dec 2006 01:37:17 -0500 Message-ID: <17782.25885.331377.660733@cube.homenetwork> References: <17721.60660.980363.609046@kahikatea.snap.net.nz> <17725.23383.490888.442550@cube.homenetwork> <17770.17915.319182.723314@cube.homenetwork> <17770.35080.725821.391914@kahikatea.snap.net.nz> <17782.25188.121126.54191@cube.homenetwork> NNTP-Posting-Host: dough.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1165433088 1631 80.91.229.10 (6 Dec 2006 19:24:48 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 6 Dec 2006 19:24:48 +0000 (UTC) Cc: rsharman@pobox.com Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Dec 06 20:24:47 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by dough.gmane.org with esmtp (Exim 4.50) id 1Gs2Nk-0000hO-A7 for ged-emacs-devel@m.gmane.org; Wed, 06 Dec 2006 20:24:40 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Gs2Nj-0003Kd-RU for ged-emacs-devel@m.gmane.org; Wed, 06 Dec 2006 14:24:39 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1GrqQv-0007tw-JF for emacs-devel@gnu.org; Wed, 06 Dec 2006 01:39:09 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1GrqQv-0007tY-27 for emacs-devel@gnu.org; Wed, 06 Dec 2006 01:39:09 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GrqQu-0007tV-Vu for emacs-devel@gnu.org; Wed, 06 Dec 2006 01:39:08 -0500 Original-Received: from [209.217.78.152] (helo=mx1-1.spamtrap.magma.ca) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA:32) (Exim 4.52) id 1GrqQu-0008L7-5w; Wed, 06 Dec 2006 01:39:08 -0500 Original-Received: from mail4.magma.ca (mail4.internal.magma.ca [10.0.10.14]) by mx1-1.spamtrap.magma.ca (8.13.1/8.13.1) with ESMTP id kB66d5Gn013750; Wed, 6 Dec 2006 01:39:05 -0500 Original-Received: from cube.homenetwork (ottawa-hs-209-217-110-164.d-ip.magma.ca [209.217.110.164]) by mail4.magma.ca (Magma's Mail Server) with ESMTP id kB66d4n1008954; Wed, 6 Dec 2006 01:39:05 -0500 Original-Received: by cube.homenetwork (Postfix, from userid 1000) id 63E2993CAA; Wed, 6 Dec 2006 01:37:17 -0500 (EST) Original-To: Nick Roberts , rms@gnu.org, emacs-devel@gnu.org In-Reply-To: <17782.25188.121126.54191@cube.homenetwork> X-Mailer: VM 7.19 under Emacs 21.4.1 X-magma-MailScanner-Information: Magma Mailscanner Service X-magma-MailScanner: Clean X-Mailman-Approved-At: Wed, 06 Dec 2006 14:23:51 -0500 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:63373 Archived-At: A few minutes ago I wrote: > > I added a new keyword :only-new EXPR which allows restricting > a change of mode to new only new buffers if EXPR is non-nil. > (So the default behaviour, without this keyword, is unchanged.) > > With this I can remove nearly all the code for the global > highlight-changes. > > Is this acceptable? Here's the change to easy-mmode.el that > implements what I need: > If you folks don't think that this is a generally useful change to define-global-minor-mode, I think I could do what I need if there was an optional turn-off function. Suppose instead of adding :only-new EXPR the macro was changed to allow an optional :turn-off FUNC keyword. Would this be deemed more acceptable? If this function were supplied then instead of arbitrarily turning off the mode in all exsiting buffers, it would call the function to possibly do so. Richard