From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Nick Roberts Newsgroups: gmane.emacs.devel Subject: Re: Bug in incremental undrawing of mouseover highlighting Date: Thu, 23 Nov 2006 12:57:06 +1300 Message-ID: <17764.58322.375625.163055@kahikatea.snap.net.nz> References: <17760.56196.739515.442009@rgrjr.dyndns.org> <87zmaludmg.fsf@cyd.mit.edu> <87u00ro6yc.fsf@cyd.mit.edu> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1164240110 1924 80.91.229.2 (23 Nov 2006 00:01:50 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 23 Nov 2006 00:01:50 +0000 (UTC) Cc: Chong Yidong , rogers-emacs@rgrjr.dyndns.org, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Nov 23 01:01:38 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1Gn221-0002wB-Lf for ged-emacs-devel@m.gmane.org; Thu, 23 Nov 2006 01:01:34 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Gn221-00044Q-Ac for ged-emacs-devel@m.gmane.org; Wed, 22 Nov 2006 19:01:33 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Gn21o-00043v-91 for emacs-devel@gnu.org; Wed, 22 Nov 2006 19:01:20 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Gn21l-00042h-DT for emacs-devel@gnu.org; Wed, 22 Nov 2006 19:01:18 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Gn21l-00042b-1D for emacs-devel@gnu.org; Wed, 22 Nov 2006 19:01:17 -0500 Original-Received: from [202.37.101.8] (helo=viper.snap.net.nz) by monty-python.gnu.org with esmtp (Exim 4.52) id 1Gn21h-0006sW-In; Wed, 22 Nov 2006 19:01:13 -0500 Original-Received: from kahikatea.snap.net.nz (p202-124-120-115.snap.net.nz [202.124.120.115]) by viper.snap.net.nz (Postfix) with ESMTP id 0A0D73D8ABA; Thu, 23 Nov 2006 13:01:51 +1300 (NZDT) Original-Received: by kahikatea.snap.net.nz (Postfix, from userid 500) id 05EBDBE448; Thu, 23 Nov 2006 12:57:07 +1300 (NZDT) Original-To: Eli Zaretskii In-Reply-To: X-Mailer: VM 7.19 under Emacs 22.0.91.2 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:62704 Archived-At: > > > Are these #ifdef's really right? The mouse highlight is supported not > > > only in builds that define HAVE_WINDOW_SYSTEM. > > > > note_mouse_highlight is only defined inside HAVE_WINDOW_SYSTEM. > > That's true, but you weren't modifying note_mouse_highlight, you > referenced dpyinfo->mouse_face_window. You will see that at least > src/msdos.c manipulates dpyinfo->mouse_face_window. The MSDOS build > supports mouse highlight, but does not define HAVE_WINDOW_SYSTEM, and > set_window_buffer, where you suggested to make the change, is compiled > into the MSDOS port. Does MSDOS know where the mouse is? Or is it like a text terminal on Unix? If it's the latter then I don't see why the MSDOS build should support mouse highlight at all. -- Nick http://www.inet.net.nz/~nickrob