From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Bob Rogers Newsgroups: gmane.emacs.devel Subject: Re: Bug in incremental undrawing of mouseover highlighting Date: Tue, 21 Nov 2006 23:06:27 -0500 Message-ID: <17763.52419.816896.10287@rgrjr.dyndns.org> References: <17760.56196.739515.442009@rgrjr.dyndns.org> <87zmaludmg.fsf@cyd.mit.edu> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1164168407 27051 80.91.229.2 (22 Nov 2006 04:06:47 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 22 Nov 2006 04:06:47 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Nov 22 05:06:44 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1GmjNg-0007wj-Fb for ged-emacs-devel@m.gmane.org; Wed, 22 Nov 2006 05:06:40 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GmjNf-0007Fi-WE for ged-emacs-devel@m.gmane.org; Tue, 21 Nov 2006 23:06:40 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1GmjNV-0007Fd-VK for emacs-devel@gnu.org; Tue, 21 Nov 2006 23:06:30 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1GmjNV-0007FR-9o for emacs-devel@gnu.org; Tue, 21 Nov 2006 23:06:29 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GmjNV-0007FO-7e for emacs-devel@gnu.org; Tue, 21 Nov 2006 23:06:29 -0500 Original-Received: from [24.128.218.106] (helo=rgrjr.dyndns.org) by monty-python.gnu.org with smtp (Exim 4.52) id 1GmjNU-0004Ww-JW for emacs-devel@gnu.org; Tue, 21 Nov 2006 23:06:28 -0500 Original-Received: (qmail 11160 invoked by uid 500); 22 Nov 2006 04:06:27 -0000 Original-To: Chong Yidong , Eli Zaretskii In-Reply-To: <87zmaludmg.fsf@cyd.mit.edu> X-Mailer: VM 7.19 under Emacs 22.0.90.1 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:62640 Archived-At: From: Chong Yidong Date: Mon, 20 Nov 2006 14:22:47 -0500 Bob Rogers writes: > It seems that mouseover background highlighting is not undrawn if > replaced by the same unhighlighted text. This happens in the CVS > version as of late on 11-Nov. The problem occurs because note_mouse_highlight checks only the window and glyph positions to see if it needs to maintain the mouse highlight . . . As far as I can tell, the simplest fix is to tell set_window_buffer to reset the mouse face if the mouse face used to be associated with that window. The patch below implements this. It works for me; thanks! From: Eli Zaretskii Date: Mon, 20 Nov 2006 22:36:22 +0200 Are these #ifdef's really right? The mouse highlight is supported not only in builds that define HAVE_WINDOW_SYSTEM. How would I test this? Mouse highlighting doesn't seem to work in either xterm or the KDE "Konsole" (with the "-nw" switch, of course). Or would I have to disable HAVE_WINDOW_SYSTEM first? -- Bob