From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: AriT93 Newsgroups: gmane.emacs.devel Subject: Re: Fwd: vc-svn.el and "the underscore hack" Date: Wed, 8 Nov 2006 15:32:00 -0600 Message-ID: <17746.19664.146987.597753@arit93.ariserve.dynup.net> References: <17735.25691.286000.488074@gargle.gargle.HOWL> <17744.49420.800000.339491@gargle.gargle.HOWL> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1163021562 5182 80.91.229.2 (8 Nov 2006 21:32:42 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 8 Nov 2006 21:32:42 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Nov 08 22:32:39 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1Ghv1x-0007Mm-Ag for ged-emacs-devel@m.gmane.org; Wed, 08 Nov 2006 22:32:21 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ghv1w-0001tg-OW for ged-emacs-devel@m.gmane.org; Wed, 08 Nov 2006 16:32:20 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Ghv1j-0001sx-6t for emacs-devel@gnu.org; Wed, 08 Nov 2006 16:32:07 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Ghv1i-0001sG-11 for emacs-devel@gnu.org; Wed, 08 Nov 2006 16:32:06 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ghv1h-0001s8-QN for emacs-devel@gnu.org; Wed, 08 Nov 2006 16:32:05 -0500 Original-Received: from [206.190.53.27] (helo=smtp102.plus.mail.re2.yahoo.com) by monty-python.gnu.org with smtp (Exim 4.52) id 1Ghv1h-0003ez-Iz for emacs-devel@gnu.org; Wed, 08 Nov 2006 16:32:05 -0500 Original-Received: (qmail 96865 invoked from network); 8 Nov 2006 21:32:04 -0000 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=yahoo.com; h=Received:X-YMail-OSG:From:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-ID:Date:To:Cc:Subject:In-Reply-To:References:X-Mailer; b=Zcgr15co2x27gdF/3FV/H647ypyeFUyCWPTqYQlshyqoZlWxP9I097e+ouJ80x1pbb4v61JG18/2v9b7Rm5bMNyQlK34FW1bM7XRSkB+lDE8jivEJL7WsQ8qq+Q96njC/LnoL+B2rbr6wJBsBhx1XUgK/GzWda45cSM7cY2dT0M= ; Original-Received: from unknown (HELO arit93.ariserve.dynup.net) (arit93@71.113.178.250 with login) by smtp102.plus.mail.re2.yahoo.com with SMTP; 8 Nov 2006 21:32:03 -0000 X-YMail-OSG: 4qEZ.UgVM1mwKspCJZl3KXnha9jOMrsEv3gSUYqK9pV1G9XI.zmtj_eWWE3od325VDtv9UVcisoYQM6jJU3BCPGma8NRwnWm8j4mrnWejmTfC6qQ9HtUkjzFL0AS1I39dBONnLiw36gszJI.O_9VxOvmB8QovbYxQk4- Original-To: Kevin Rodgers In-Reply-To: X-Mailer: VM 7.19 under Emacs 22.0.90.1 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:61966 Archived-At: Kevin Rodgers writes: > AriT93 wrote: > > As I mentioned earlier I have made a different change utilizing the > > defun from psvn.el since that seemed a cleaner solution that what I > > had done previously. > > > > As described before this patch addresses the > > issue that vc-svn does not recognize svn repositories on win32 systems > > that use the "underscore hack" and have the svn admin directory as > > "_svn" instead of ".svn" > > > > In testing this morning i noticed that in order for make bootstrap to > > work with the change I had to mark it as an autoload. I understand > > the reason but is this the correct way for the defuns to be used. I > > guess I'm unclear on why vc-svn-registered needs an autoload. I made > > svn-wc-adm-dir-name an autoload as it is used in vc-svn-registered. > > > > I have included text attributing the chage to the work done in psvn.el > > I hope that I have done it in a way that is acceptable. Would that > > text be better suited to the Commentary section? If so let me now and > > I'll move it and resubmit the patch. > > Wouldn't it be simpler and more reliable to change > > (when (file-readable-p (expand-file-name ".svn" FILE)) > ;; refer to (expand-file-name ".svn" FILE) here > ...) > > to > > (let (svn-file) > (cond ((file-readable-p (setq svn-file (expand-file-name ".svn" FILE)))) > ((file-readable-p (setq svn-file (expand-file-name "_svn" FILE)))) > (t (setq svn-file nil))) > (when svn-file > ;; refer to svn-file here > ...)) > > and similarly for the file-directory-p and vc-insert-file calls? > > -- > Kevin > > > > _______________________________________________ > Emacs-devel mailing list > Emacs-devel@gnu.org > http://lists.gnu.org/mailman/listinfo/emacs-devel That would be similar to the first patch that I submitted. it seemed to me that this method might be a bit easier to maintain long term as the decision to use .svn over _svn is in one place. Although the statements above could also set svn-file in the same way I suppose. -- enjoy every sandwich -- W. Zevon