unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Paul Eggert <eggert@cs.ucla.edu>
To: Daniel Colascione <dancol@dancol.org>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master 8e2b2a2: Minor cleanup in pdumper.c
Date: Sat, 19 Jan 2019 13:53:26 -0800	[thread overview]
Message-ID: <176c3ec3-7c6a-8f89-b31c-66c8cd129339@cs.ucla.edu> (raw)
In-Reply-To: <4508562eb2e3fe5fedd01263f6c39d5c.squirrel@dancol.org>

Daniel Colascione wrote:
> Ah, never mind. I saw the constants at the end of the patch and jumped the
> gun.

While we're on the subject, why does pdumper-stats return milliseconds? 
Returning seconds would be simpler, and the number is a float so I don't see the 
point of picking some other unit of measure.



  reply	other threads:[~2019-01-19 21:53 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20190119182259.26893.32117@vcs0.savannah.gnu.org>
     [not found] ` <20190119182301.0DE562043D@vcs0.savannah.gnu.org>
2019-01-19 21:33   ` [Emacs-diffs] master 8e2b2a2: Minor cleanup in pdumper.c Daniel Colascione
2019-01-19 21:35     ` Daniel Colascione
2019-01-19 21:53       ` Paul Eggert [this message]
2019-01-19 21:56         ` Daniel Colascione
2019-01-19 22:41           ` Paul Eggert
2019-01-20  3:44             ` Eli Zaretskii
2019-01-21 20:49               ` Paul Eggert
2019-01-21 22:46                 ` Daniel Colascione
2019-01-22  7:24                   ` Paul Eggert
2019-01-22 16:53                     ` Eli Zaretskii
2019-01-23  1:29                       ` Daniel Colascione
2019-01-23 22:07                         ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=176c3ec3-7c6a-8f89-b31c-66c8cd129339@cs.ucla.edu \
    --to=eggert@cs.ucla.edu \
    --cc=dancol@dancol.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).