From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Nick Roberts Newsgroups: gmane.emacs.devel Subject: Re: C-g crash redux Date: Fri, 4 Aug 2006 12:59:10 +1200 Message-ID: <17618.39902.366454.652358@kahikatea.snap.net.nz> References: <877j1qvp4k.fsf@pacem.orebokech.com> <17617.8764.824445.882539@kahikatea.snap.net.nz> <87fygd97j0.fsf@stupidchicken.com> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1154653283 9736 80.91.229.2 (4 Aug 2006 01:01:23 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 4 Aug 2006 01:01:23 +0000 (UTC) Cc: Romain Francoise , emacs-devel@gnu.org, "Kim F. Storm" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Aug 04 03:01:19 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1G8o3r-0001xO-1X for ged-emacs-devel@m.gmane.org; Fri, 04 Aug 2006 03:01:11 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1G8o3q-0002CF-Jp for ged-emacs-devel@m.gmane.org; Thu, 03 Aug 2006 21:01:10 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1G8o3e-0002Aq-IM for emacs-devel@gnu.org; Thu, 03 Aug 2006 21:00:58 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1G8o3c-00029s-Bd for emacs-devel@gnu.org; Thu, 03 Aug 2006 21:00:58 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1G8o3c-00029p-7i for emacs-devel@gnu.org; Thu, 03 Aug 2006 21:00:56 -0400 Original-Received: from [202.37.101.8] (helo=viper.snap.net.nz) by monty-python.gnu.org with esmtp (Exim 4.52) id 1G8o73-0003Ts-OL for emacs-devel@gnu.org; Thu, 03 Aug 2006 21:04:30 -0400 Original-Received: from kahikatea.snap.net.nz (p202-124-125-174.snap.net.nz [202.124.125.174]) by viper.snap.net.nz (Postfix) with ESMTP id EBACC77FED8; Fri, 4 Aug 2006 13:00:49 +1200 (NZST) Original-Received: by kahikatea.snap.net.nz (Postfix, from userid 500) id 75ADCBE3B3; Fri, 4 Aug 2006 12:59:15 +1200 (NZST) Original-To: Chong Yidong In-Reply-To: <87fygd97j0.fsf@stupidchicken.com> X-Mailer: VM 7.19 under Emacs 22.0.50.16 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:58073 Archived-At: > Typing C-g, which runs interrupt_signal, runs quit_throw_to_read_char > instead of Fsignal during when waiting_for_input is set (as it is > during wait_reading_process_output). keyboard-quit goes through interrupt_signal -> quit_throw_to_read_char and then calls Fsignal i.e it's not necessarily an alternative. > If I understand correctly, the > purpose is to enable read-char to return a `C-g' character; and that's > why it's both undesirable and unnecesssary to use a > record_unwind_protect inside wait_reading_process_output. I don't follow. > I'll go ahead and revert the 2006-08-01 change. I think that cures the symptom not the cause. -- Nick http://www.inet.net.nz/~nickrob