unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Rüdiger Sonderfeld" <ruediger@c-plusplus.de>
To: Tassilo Horn <tsdh@gnu.org>
Cc: auctex-devel@gnu.org, emacs-devel@gnu.org
Subject: Re: [PATCH 2/2] Add tests for reftex.
Date: Wed, 12 Jun 2013 15:57:47 +0200	[thread overview]
Message-ID: <1761405.fvgUXIz0hW@descartes> (raw)
In-Reply-To: <87li6flcfo.fsf@thinkpad.tsdh.de>

Hi,

On Wednesday 12 June 2013 14:51:23 Tassilo Horn wrote:
> F reftex-parse-from-file-test
>     Test `reftex-parse-from-file'.
>     (wrong-type-argument stringp nil)

sorry this was a problem caused by an uninitialised variable.  I guess that's 
why I didn't caught it.

Adding (reftex-ensure-compiled-variables) prior to the call to `reftex-parse-
from-file' fixes the issue.

--8<--------------------->8---
diff --git a/test/automated/reftex-tests.el b/test/automated/reftex-tests.el
index 5f5b008..de7f36d 100644
--- a/test/automated/reftex-tests.el
+++ b/test/automated/reftex-tests.el
@@ -115,6 +115,7 @@ (ert-deftest reftex-parse-from-file-test ()
     (with-temp-buffer
       (insert "test\n")
       (write-region (point-min) (point-max) bib-file))
+    (reftex-ensure-compiled-variables)
     (let ((parsed (reftex-parse-from-file tex-file nil temp-dir)))
       (should (equal (car parsed) `(eof ,tex-file)))
       (pop parsed)
--8<--------------------->8---

> I've never used ert.  Is there a way to tell it to also include the line
> number where it failed?

In ert you can get the backtrace by pressing `b'.

Regards
Rüdiger


_______________________________________________
auctex-devel mailing list
auctex-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/auctex-devel

  reply	other threads:[~2013-06-12 13:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <752231878d20023a1d624e71ea4edc15bd10cf78.1370979894.git.ruediger@c-plusplus.de>
2013-06-11 19:46 ` [PATCH 2/2] Add tests for reftex Rüdiger Sonderfeld
2013-06-12 12:51   ` Tassilo Horn
2013-06-12 13:57     ` Rüdiger Sonderfeld [this message]
2013-06-12 14:47       ` Tassilo Horn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1761405.fvgUXIz0hW@descartes \
    --to=ruediger@c-plusplus.de \
    --cc=auctex-devel@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=tsdh@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).