From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Nick Roberts Newsgroups: gmane.emacs.devel Subject: Re: comint-insert-input on non-command lines: A trivial fix, a quibble, and a bug Date: Wed, 10 May 2006 15:50:37 +1200 Message-ID: <17505.25357.397260.50040@farnswood.snap.net.nz> References: <17501.373.791079.156322@rgrjr.dyndns.org> <17502.37204.411491.461843@farnswood.snap.net.nz> <200605080408.k4848t65027552@jane.dms.auburn.edu> <17502.50834.303952.808659@farnswood.snap.net.nz> <200605090301.k4931NbZ010512@jane.dms.auburn.edu> <17504.2770.189282.768887@farnswood.snap.net.nz> <200605090359.k493xjVi010576@jane.dms.auburn.edu> <17504.13295.579987.394734@farnswood.snap.net.nz> <200605091458.k49EwOL8012994@jane.dms.auburn.edu> <20060510010929.723AA627ED@farnswood.snap.net.nz> <17505.19996.720964.47189@farnswood.snap.net.nz> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1147233126 25692 80.91.229.2 (10 May 2006 03:52:06 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 10 May 2006 03:52:06 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed May 10 05:52:02 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1Fdfju-0000e5-Aw for ged-emacs-devel@m.gmane.org; Wed, 10 May 2006 05:51:55 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Fdfjs-0002Jl-NB for ged-emacs-devel@m.gmane.org; Tue, 09 May 2006 23:51:52 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Fdfji-0002JY-JO for emacs-devel@gnu.org; Tue, 09 May 2006 23:51:42 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1FdfjZ-0002Iu-Ie for emacs-devel@gnu.org; Tue, 09 May 2006 23:51:41 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FdfjZ-0002Ir-DS for emacs-devel@gnu.org; Tue, 09 May 2006 23:51:33 -0400 Original-Received: from [202.37.101.8] (helo=viper.snap.net.nz) by monty-python.gnu.org with esmtp (Exim 4.52) id 1Fdfkb-0003iu-Kt; Tue, 09 May 2006 23:52:38 -0400 Original-Received: from farnswood.snap.net.nz (p202-124-114-235.snap.net.nz [202.124.114.235]) by viper.snap.net.nz (Postfix) with ESMTP id A7A5A7524C6; Wed, 10 May 2006 15:51:14 +1200 (NZST) Original-Received: by farnswood.snap.net.nz (Postfix, from userid 500) id 47558627ED; Wed, 10 May 2006 04:50:38 +0100 (BST) Original-To: Miles Bader In-Reply-To: X-Mailer: VM 7.19 under Emacs 22.0.50.51 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:54166 Archived-At: > Christ, take a pill... If you just made the trivial change and explained why I wouldn't have to. Now your change: * comint.el (comint-insert-input): Remove redundant calls to setq and goto-char. looks good to me, but Stefan specifically added them on 2005-03-24: * comint.el (comint-insert-input): Obey mouse-yank-at-point. Are you sure they are redundant? -- Nick http://www.inet.net.nz/~nickrob